Kuma: Editors table tools leads to non-adequate HTML

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: teoli, Unassigned)

Tracking

Details

Comment hidden (empty)
(Reporter)

Comment 1

7 years ago
When using the internal table editor tools, it adds tags with deprecated/obsolete values like:
 <table border="1" cellpadding="1" cellspacing="1" style="width: 500px; height: 4px">

border, cellpadding, cellspacing are bad.
Even width and height are not good (as we want to minimize the usage of the attribute size).

The UI should be modified not to propose border, cellpadding, cellspacing, width and height. Instead a field with potential classes should be added. (They can be hardcoded, we don't have hundreds of them and we don't add often).

(This is a prerequisite to tighten Bleach whiteliste by removing border, cellpadding and cellspacing.)

Priority: post-launch of course; but it is annoying to see these fields used by editors and to have to fix the pages afterwards.

Comment 2

6 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/234ef39b52667d51aabcb7b9586d7a6e145b4999
fix bug 778630 - Make table dialog more standards-compliant

https://github.com/mozilla/kuma/commit/3f508d7045385b80a27822e209258f416baa99d7
Merge pull request #477 from darkwing/remove-table-fields-778630

fix bug 778630 - Make table dialog more standards-compliant

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Version: Kuma → unspecified
Component: Docs Platform → Editing
Product: Mozilla Developer Network → Mozilla Developer Network
You need to log in before you can comment on or make changes to this bug.