778777 - Kill rdf/tests

Status: RESOLVED FIXED

(Core Graveyard :: RDF, defect)

Description

[(not currently active) Ted Mielczarek]

We build these three test binaries for every build, but AFAIK they aren't used for anything. I doubt anyone is using them, so we should stop wasting time building them.

Comment 1

[Axel Hecht]

I can't find any uses ad-hoc, and I surely don't have any personally.

Disclaimer, I'm not doing any real coding these days.

The only helpful thing with these is that we're ensuring that these still build, in case someone would need them to dig in to actually doing some changes on rdf stuff.

Comment 2

[Trevor Saunders (:tbsaunde)]

Attachment: kill all off rdf/tests/ except the xpc shell test

Comment 3

[Axel Hecht]

Comment on attachment 649535 [details] [diff] [review]
kill all off rdf/tests/ except the xpc shell test

Review of attachment 649535 [details] [diff] [review]:
-----------------------------------------------------------------

We should keep rdfcat and triplescat. I don't think they necessarily need to be built all the time, but we should keep them around, and have a makefile to actually build them if needed.

Comment 4

[Axel Hecht]

PS: please keep this bug to my rdf-me, the l10n watchers don't need to be bothered with it.

Comment 5

[(not currently active) Ted Mielczarek]

Why should we keep code around that we're not building? Nothing uses these tools. Not wasting time building them is a great first step, but leaving code that we're not building is just silly. It will bitrot and nobody will notice.

Comment 6

[Trevor Saunders (:tbsaunde)]

(In reply to Ted Mielczarek [:ted] from comment #5)
> Why should we keep code around that we're not building? Nothing uses these
> tools. Not wasting time building them is a great first step, but leaving
> code that we're not building is just silly. It will bitrot and nobody will
> notice.

agreed, also it'll be confusing to people trying to see if things are still used, or if they can be removed.

Comment 7

[Axel Hecht]

IMHO, bitrotting them is gonna be better than having not a single tool for hunting regressions in case we actually have to change something within RDF.

Comment 8

[Trevor Saunders (:tbsaunde)]

(In reply to Axel Hecht from comment #7)
> IMHO, bitrotting them is gonna be better than having not a single tool for
> hunting regressions in case we actually have to change something within RDF.

isn't that what tests are for?

We seem to have several tests that use bits of rdf after this patch rdf/tests/unit/ which is an xpcshell test content/xslt/tests/buster I'm not clear on exactly what that does, and  a bunch of tests in toolkit/ in toolkit/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5665e562fb2
kill off most of rdf/tests/ irc-r=ted

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f5665e562fb2