Closed Bug 778845 Opened 9 years ago Closed 9 years ago

Must upgrade Aurora 16 to NSPR 4.9.2 final

Categories

(Core :: General, defect)

16 Branch
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla17
Tracking Status
firefox16 --- fixed

People

(Reporter: KaiE, Unassigned)

Details

Attachments

(1 file)

The Aurora 16 branch currently uses NSPR 4.9.2 beta.
We must upgrade it to 4.9.2 final because of policy.

There was one change between beta and final:


Bug 758837: add a comment to explain the source of the 15-char name length
limit.  Copy the null terminator from the input thread name.  r=honzab.
Attached patch dummy patchSplinter Review
Attachment #647243 - Flags: approval-mozilla-aurora?
Summary: Must upgrade Aurora to NSPR 4.9.2 final → Must upgrade Aurora 16 to NSPR 4.9.2 final
Please approve and land bug 766038 on Aurora 16, too.
Comment on attachment 647243 [details] [diff] [review]
dummy patch

permission from wtc during today's meeting
Attachment #647243 - Flags: review+
Attachment #647243 - Flags: review+
(In reply to Kai Engert (:kaie) from comment #4)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/38b216220e60

You forgot to make a dummy change to nsprpub/config/prdepend.h.
https://hg.mozilla.org/mozilla-central/rev/38b216220e60
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Next time, please use:
$ python client.py update_nspr NSPR_4_9_2_RTM
Attachment #647243 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
> You forgot to make a dummy change to nsprpub/config/prdepend.h.

yes indeed, I will when landing on aurora (not to readers, this is simply to force a rebuild).


> $ python client.py update_nspr NSPR_4_9_2_RTM

That's what I did? Why do you believe I didn't?
Or do you refer to the contents of the attachment?
Wan-Teh, should we file a bug that suggests to enhance the client.py script, to automatically apply a dummy change to the header file, by appending an empty line? We can eventually clean up the lines that get added over time, but it will make sure we won't forget about it.
(In reply to Kai Engert (:kaie) from comment #8)
> > $ python client.py update_nspr NSPR_4_9_2_RTM
> 
> That's what I did? Why do you believe I didn't?

Because it should have picked the nsprpub/config/prdepend.h change.
(In reply to Mike Hommey [:glandium] from comment #11)
> (In reply to Kai Engert (:kaie) from comment #8)
> > > $ python client.py update_nspr NSPR_4_9_2_RTM
> > 
> > That's what I did? Why do you believe I didn't?
> 
> Because it should have picked the nsprpub/config/prdepend.h change.

I mean, it does if I run it...
> > Because it should have picked the nsprpub/config/prdepend.h change.
> I mean, it does if I run it...


I don't see code in client.py to update that file.
We do that manually.

If you saw that file changed, then that file in the release is different from the one that you were using in your local tree.
We frequently change this file in order to trigger rebuilds.

If comment 9 I suggest to enhance client.py to automatically add a dummy line to the dummy file whenever we use the script to update NSPR (or NSS, different file), so we won't forget about it and can avoid confusion.

If you like this idea, we should file a bug.
I think this would be a good change to client.py.

We should be more sophisticated: if the last line of prdepend.h is a blank line,
remove it. Otherwise, append a blank line.
> We should be more sophisticated: if the last line of prdepend.h is a blank
> line, remove it. Otherwise, append a blank line.

I've implemented the proposal in bug 782784.
You need to log in before you can comment on or make changes to this bug.