Created attachment 647326 [details] [diff] [review]
E4X is disabled by default in the shell; you have to turn it on using
Up to now, the root shell.js script contained such an options() call, so E4X was effectively enabled for all JS tests, but only when they run in the shell.
With this patch, allow_xml is off by default in tests, and you can turn it on by using the magic comment
The magic comment already worked in the jsreftest test harness, so it is already there for all E4X-using tests that run in the browser.
Up to now the shell test harness didn't know about this pref() thingy and it just spat out a warning. Now the shell test harness also honors this setting. I had to add the magic comment to a few tests that don't run in the browser.
Created attachment 647572 [details] [diff] [review]
Rebased on top of terrence's patch in bug 778383
Carrying forward review.
I think this is the first time Python's mutating += has bitten me. Pythons don't usually bite (they crush their prey).