Closed Bug 778921 Opened 10 years ago Closed 10 years ago

"warning: invalid manifest line element "pref(javascript.options.xml.content,true)" running jstests.py

Categories

(Core :: JavaScript Engine, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch v1 (obsolete) — Splinter Review
E4X is disabled by default in the shell; you have to turn it on using
  options('allow_xml');

Up to now, the root shell.js script contained such an options() call, so E4X was effectively enabled for all JS tests, but only when they run in the shell.

With this patch, allow_xml is off by default in tests, and you can turn it on by using the magic comment

// |reftest| pref(javascript.options.xml.content,true)

The magic comment already worked in the jsreftest test harness, so it is already there for all E4X-using tests that run in the browser.

Up to now the shell test harness didn't know about this pref() thingy and it just spat out a warning. Now the shell test harness also honors this setting. I had to add the magic comment to a few tests that don't run in the browser.
Assignee: general → jorendorff
Attachment #647326 - Flags: review?(luke)
Attachment #647326 - Flags: review?(luke) → review+
Carrying forward review.
Attachment #647326 - Attachment is obsolete: true
Attachment #647572 - Flags: review+
Embarrassing:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fa54a1fc055

I think this is the first time Python's mutating += has bitten me. Pythons don't usually bite (they crush their prey).
https://hg.mozilla.org/mozilla-central/rev/25e961798919
https://hg.mozilla.org/mozilla-central/rev/9fa54a1fc055
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.