Closed Bug 779046 Opened 8 years ago Closed 8 years ago

Default the nativeType for WebIDL bindings to mozilla::dom::IfaceName

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

E.g. Element would become mozilla::dom::Element.
Comment on attachment 647452 [details] [diff] [review]
Have saner defaults for the nativeType of a WebIDL bindings.

Review of attachment 647452 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Configuration.py
@@ +129,5 @@
>          # Read the desc, and fill in the relevant defaults.
> +        ifaceName = self.interface.identifier.name
> +        if self.interface.isExternal() or self.interface.isCallback():
> +            if self.workers:
> +                nativeTypeDefault = "JSObject"

I'm not convinced that doing this silently is a good idea. Wouldn't we be able to drop most of these cases if we were able to mark some methods / attributes as being supported only on the main thread?
I'm not sure.  Ben?
Attachment #647452 - Flags: review?(peterv) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/561f1e6ccdc9
Whiteboard: [need review]
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/561f1e6ccdc9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.