Open Bug 779053 Opened 12 years ago Updated 2 years ago

Refactor XPIProvider.processFileChanges

Categories

(Toolkit :: Add-ons Manager, defect, P3)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

People

(Reporter: Unfocused, Unassigned)

References

(Blocks 1 open bug)

Details

XPIProvider.processFileChanges is huge and complex and huge. Also, it is quite big.

Dunno how much the complexity can be reduced, but I'd like to see it refactored so it at least fits in my brain easier. 

* There's a bunch of inner functions at the start that can easily be moved out
* Of those, addMetadata is quite large and complex also, and does a lot more than just "add metadata"
* There's a few loops that can be spun off into separate functions
* Generally spin off utility functions for stuff not directly related to the main task
Blocks: aom-code-quality
Priority: -- → P2
Priority: P2 → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.