779103 - [UI] ADU - If no ADU results plot causes error breaking UI

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Schalk Neethling [:espressive]]

If one loads Crashes by ADU and there is no data for the graph it causes the following JS error:

"uncaught exception: Invalid dimensions for plot, width = null, height = null"

Because of this error all other JS does not execute and hence the UI is broken as a user can no longer select different reports for example, switching to by OS.

Only draw plot if there is data available.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0fb909f5817c4d1ae4a23f30dfd5571384bb9f25
only plotting content if data is available fixes bug 779103

https://github.com/mozilla/socorro/commit/cb426b820991354268316562fa29c906141f9ede
Merge pull request #756 from ossreleasefeed/adu-only-plot-if-data-available-779103

only plotting content if data is available fixes bug 779103

Comment 2

[Schalk Neethling [:espressive]]

Sent pull request: https://github.com/mozilla/socorro/pull/756

TEST CASE
---------

If you navigate to crashes per ADU and there is no data or you generate a new report for which there is no data, a JS error will no longer be thrown and thus the interface will still be fully functional.

Comment 3

[Matt Brandt [:mbrandt]]

Reopened: 

I'm not sure if this is a lack of data (or I'm generating the report with the wrong query) but I'm unable to find a report that has data.

Examples:
https://crash-stats.allizom.org/daily?form_selection=by_version&p=FennecAndroid&v[]=17.0a1&v[]=16.0a2&v[]=15.0b3&v[]=14.0.1&hang_type=any&os[]=Windows&os[]=Mac&os[]=Linux&date_start=2012-06-01&date_end=2012-08-16&submit=Generate

https://crash-stats.allizom.org/daily?form_selection=by_version&p=Firefox&v[]=17.0a1&v[]=16.0a2&v[]=15.0b3&v[]=14.0.1&hang_type=any&os[]=Windows&os[]=Mac&os[]=Linux&date_start=2012-06-01&date_end=2012-08-16&submit=Generate

https://crash-stats.allizom.org/daily?form_selection=by_os&p=Firefox&v[]=14.0.1&hang_type=any&date_start=2012-06-01&date_end=2012-08-16&submit=Generate

https://crash-stats.allizom.org/daily?form_selection=by_os&p=Firefox&v[]=15.0b1&hang_type=any&date_start=2012-06-01&date_end=2012-08-16&submit=Generate

https://crash-stats.allizom.org/daily?form_selection=by_report_type&p=Firefox&v[]=15.0b1&v[]=14.0.1&v[]=10.0.6esr&v[]=15.0b4&report_type[]=crash&report_type[]=oopp&report_type[]=hang_browser&report_type[]=hang_plugin&os[]=Windows&os[]=Mac&os[]=Linux&date_start=2012-06-01&date_end=2012-08-16&submit=Generate

Comment 4

[Robert Kaiser]

Right, as the front page has data, https://crash-stats.allizom.org/daily?p=Firefox&v[]= should also show some, but there is none at all.

Comment 5

[Schalk Neethling [:espressive]]

[:mbrandt] This is because the needed changes for crashes per ADU has not been made for Mobeta so, this still uses and old service that will return no data. This bug is specific to the JS error that was thrown when this page is loaded without data.

Comment 6

[Matt Brandt [:mbrandt]]

Thanks espressive

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using: 

https://crash-stats.allizom.org/daily?form_selection=by_os&p=Firefox&v[]=10.0.5esr&hang_type=any&date_range_type=build&date_start=2012-08-23&date_end=2012-09-06&submit=Generate (and other queries).

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot