779107 - Session restore is broken after Bug 769960 is fixed

Status: RESOLVED INVALID

(Toolkit :: Safe Browsing, defect)

Description

[ojab]

Attachment: My mozconfig

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20100101 Firefox/14.0.1
Build ID: 20120717144008

Steps to reproduce:

1. Make a new Profile
2. Close existing tabs, open http://ya.ru
3. Close Fx
4. Start Fx
5. Click "Restore previous session" button


Actual results:

There is no "Restore previous session" button


Expected results:

Previous session restored.

r100810:a9502620734e works fine, r100811:3b312c31d1cd is broken.

Comment 1

[ojab]

Firefox was build from mozilla-inbound repo.

Comment 2

[ojab]

One more thing: I'm using firefox without installation, running ~/opt/browser/dist/bin/firefox.

In r100811:3b312c31d1cd there is also two additional Warnings/Errors in Error Console:

Could not read chrome manifest 'file:///home/ojab/opt/browser/dist/bin/components/nsSafebrowsingApplication.manifest'.
Timestamp: 31.07.2012 17:36:13
Error: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
Source File: chrome://browser/content/browser.js
Line: 143

Comment 3

[Justin Dolske [:Dolske]]

Have you done a complete build since 769960 landed? nsSafebrowsingApplication.manifest doesn't exist any more, so it sounds like something in your tree is out of date.

Comment 4

[Philip Chee]

Justin, perhaps you should add those deleted files to /browser/installer/removed-files.in

Comment 5

[ojab]

Sorry for the noise, my fault. Something was rotten in my build tree, fresh hg clone works without that issue.

Comment 6

[Justin Dolske [:Dolske]]

(In reply to Philip Chee from comment #4)
> Justin, perhaps you should add those deleted files to
> /browser/installer/removed-files.in

Why? I don't think anything shipped outside of jars.