Closed
Bug 779149
Opened 12 years ago
Closed 12 years ago
[Dialer] Audio does not go through headset
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(blocking-basecamp:+)
VERIFIED
FIXED
blocking-basecamp | + |
People
(Reporter: nhirata, Assigned: slee)
References
Details
Attachments
(1 file, 1 obsolete file)
9.60 KB,
patch
|
slee
:
review+
|
Details | Diff | Splinter Review |
Environment : Otoro phone, build 2012-07-30 Taken from default.xml in b2g-distro: "platform_build" revision= 2163d79 "gaia" revision= 759caf5 "mozilla-central" revision= 07226cf "gonk-misc" revision= c6a9a25 Repro : 1) plug in headset 2) open dialer 3) make a call Expected : the number tones should go through the headset, the call audio should go through the headset Actual : all audio goes through speaker of the phone Note : it's easier to hear calls imo through a headset for mobile devices... Gaia issue : https://github.com/mozilla-b2g/gaia/issues/2971
Comment 1•12 years ago
|
||
Agreed, audio should go through the headset. Nom'ing for basecamp.
blocking-basecamp: --- → ?
Comment 2•12 years ago
|
||
Hi Steven, is it related to Bug 745078 you are working on?
Assignee | ||
Comment 3•12 years ago
|
||
Yes, the headset uevent behavior is different from SGS2. I fixed it in Bug 745075. It should be landed soon.
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to StevenLee from comment #3) > Yes, the headset uevent behavior is different from SGS2. I fixed it in Bug > 745075. It should be landed soon. I am sorry for the typo, it should be Bug 745078.
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Comment 6•12 years ago
|
||
qawanted added, because bug 745078 is reso-fixed, but we need confirmation it really fixes this bug.
blocking-basecamp: + → ?
Updated•12 years ago
|
QA Contact: dclarke
Comment 7•12 years ago
|
||
Tested on a nexus s and on a galaxy s2 with today's b2g build. The tones when you call a number and the ringtone when you get a call go through the headset. However the phone call sound doesn't go through the headset.
Assignee | ||
Comment 9•12 years ago
|
||
Hi mwu, The way to change audio routing is different when upgrading to ICS. I modify the functions to set audio routing. Please check it.
Attachment #651383 -
Flags: review?(mwu)
Comment 10•12 years ago
|
||
I'll assume this isn't a dupe then.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 11•12 years ago
|
||
Comment on attachment 651383 [details] [diff] [review] patch Review of attachment 651383 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/libsydneyaudio/src/gonk/AudioSystem.h @@ +223,5 @@ > } audio_channels_t; > > #endif > > +//#ifdef VANILLA_ANDROID Remove this line @@ +311,5 @@ > + AUDIO_POLICY_DEVICE_STATE_CNT, > + AUDIO_POLICY_DEVICE_STATE_MAX = AUDIO_POLICY_DEVICE_STATE_CNT - 1, > +} audio_policy_dev_state_t; > + > +//#endif //VANILLA_ANDROID Remove this line too
Attachment #651383 -
Flags: review?(mwu) → review+
Assignee | ||
Comment 12•12 years ago
|
||
Attachment #651383 -
Attachment is obsolete: true
Attachment #652094 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 13•12 years ago
|
||
Pushing without Try results since b2g-only. https://hg.mozilla.org/integration/mozilla-inbound/rev/e16055525c59
Assignee: nobody → slee
Keywords: checkin-needed
Comment 14•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e16055525c59
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•