779287 - widget/android: replace NULL with nullptr

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Chris Peterson [:cpeterson]]

Attachment: replace-NULL-with-nullptr.patch

Now that bug 626472 (Switch from nsnull to nullptr) has landed, Gecko code is migrating to C++11's magic `nullptr` constant (or an equivalent `nullptr` macro for pre-C++11 compilers).

In new Android code, we ought to use nullptr in place of NULL, nsnull, or the 0 pointer. nullptr does not give us much benefit with Android's gcc 4.4, but NDK r8b's gcc 4.6 will give us better nullptr warnings.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 647660 [details] [diff] [review]
replace-NULL-with-nullptr.patch

You should probably send to Try just to make sure the build system on tinderbox is OK to handle these changes. I assume it will be fine, but you know how it goes.

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> You should probably send to Try just to make sure the build system on
> tinderbox is OK to handle these changes. I assume it will be fine, but you
> know how it goes.

Will do.

Comment 3

[Chris Peterson [:cpeterson]]

Android tests were green (save for a few XUL tests):
https://tbpl.mozilla.org/?tree=Try&rev=3a3b42304b8d

And other platform builds were green:
https://tbpl.mozilla.org/?tree=Try&rev=98bfe405937c

Comment 4

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6aff596b0ff

Comment 5

[Chris Peterson [:cpeterson]]

backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/412282a35c2d

Ms2ger says: "Doing it for the whole code base is fine; it means you can do s/nsnull/nullptr/ on your patch queue *once*; if you do it module by module, you have to fix up *parts* of your patch queue a couple dozen times."