widget/android: replace NULL with nullptr

RESOLVED WONTFIX

Status

()

Firefox for Android
General
P4
normal
RESOLVED WONTFIX
6 years ago
6 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
Firefox 17
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox17 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 647660 [details] [diff] [review]
replace-NULL-with-nullptr.patch

Now that bug 626472 (Switch from nsnull to nullptr) has landed, Gecko code is migrating to C++11's magic `nullptr` constant (or an equivalent `nullptr` macro for pre-C++11 compilers).

In new Android code, we ought to use nullptr in place of NULL, nsnull, or the 0 pointer. nullptr does not give us much benefit with Android's gcc 4.4, but NDK r8b's gcc 4.6 will give us better nullptr warnings.
Attachment #647660 - Flags: review?(mark.finkle)
(Assignee)

Updated

6 years ago
Summary: Replace NULL with nullptr → widget/android: replace NULL with nullptr
Comment on attachment 647660 [details] [diff] [review]
replace-NULL-with-nullptr.patch

You should probably send to Try just to make sure the build system on tinderbox is OK to handle these changes. I assume it will be fine, but you know how it goes.
Attachment #647660 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 2

6 years ago
(In reply to Mark Finkle (:mfinkle) from comment #1)
> You should probably send to Try just to make sure the build system on
> tinderbox is OK to handle these changes. I assume it will be fine, but you
> know how it goes.

Will do.
(Assignee)

Comment 3

6 years ago
Android tests were green (save for a few XUL tests):
https://tbpl.mozilla.org/?tree=Try&rev=3a3b42304b8d

And other platform builds were green:
https://tbpl.mozilla.org/?tree=Try&rev=98bfe405937c
(Assignee)

Comment 5

6 years ago
backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/412282a35c2d

Ms2ger says: "Doing it for the whole code base is fine; it means you can do s/nsnull/nullptr/ on your patch queue *once*; if you do it module by module, you have to fix up *parts* of your patch queue a couple dozen times."
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-firefox16: unaffected → ---
status-firefox17: fixed → affected
Priority: P3 → P4
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.