779354 - Exclude Hotfix add-on from compatibility bumps

Status: RESOLVED INCOMPLETE

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Matthew N. [:MattN]]

The Firefox hotfix extension is marked as compatible with 10.0 - 12.* in its install.rdf[1] along with <em:strictCompatibility>true</em:strictCompatibility> but for some reason it is now shown as "Works with Firefox 10.0 - 14.0" on the public pages and in the update check API[2].

Was there an automated version bump strictCompatibility extensions?

[1] https://addons.mozilla.org/en-US/firefox/files/browse/150316/file/install.rdf
[2] https://addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=[e-mail]&version=&maxAppVersion=%ITEM_MAXAPPVERSION%&status=userEnabled,incompatible&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=14.0&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=14.0&updateType=%UPDATE_TYPE%&compatMode=%COMPATIBILITY_MODE%

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

The strictCompatibility flag is meant to override Default To Compatible, but not the compatibility bumps that we still do on AMO.

You can revert the compatibility bump by visiting the Status and Versions page, selecting the version and then adjusting the compatibility information. I can do that for you if necessary.

I don't think we want to exclude strictCompatibility add-ons from the bumps, since they work independently from DTC. If this is an important requirement for the Hotfix extension, we could exclude it from the compat bumps, individually.

Comment 2

[Matthew N. [:MattN]]

(In reply to Jorge Villalobos [:jorgev] from comment #1)
> The strictCompatibility flag is meant to override Default To Compatible, but
> not the compatibility bumps that we still do on AMO.
>
> You can revert the compatibility bump by visiting the Status and Versions
> page, selecting the version and then adjusting the compatibility
> information. I can do that for you if necessary.

By that time it may be too late since hotfixes are automatically installed during a daily check if a compatible version exists on AMO.  If we are targeting specific versions there may be undesired consequences of a hotfix getting installed in a newer version of Firefox, not to mention the unnecessary download traffic from possibly millions of installs.

> I don't think we want to exclude strictCompatibility add-ons from the bumps,
> since they work independently from DTC. If this is an important requirement
> for the Hotfix extension, we could exclude it from the compat bumps,
> individually.

AFAICT the compatibility bumps and DTC both had the same basic intention of allowing extensions written for older application versions (indicated by their maxVersion) to be installed in newer application versions.  It would seem to me that the same method of preventing this override should work for both cases (DTC and bumps).

In the meantime, please exclude firefox hotfixes (ID: [e-mail]) from compatibility bumps as we'll be putting two more out soon.  Could you also fix the current Windows one[1] to target 10 - 12.* (like the install.rdf)?

Thanks

[1] https://addons.mozilla.org/en-US/firefox/addon/firefox-hotfix/versions/?page=1#version-20120430.01

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Matthew N. [:MattN] from comment #2)
> In the meantime, please exclude firefox hotfixes (ID:
> [e-mail]) from compatibility bumps as we'll be putting two
> more out soon.  

OK. This bug is about doing that now.

> Could you also fix the current Windows one[1] to target 10 -
> 12.* (like the install.rdf)?

Done.

Comment 4

[Wil Clouser [:clouserw]]

Is this bug still valid?

And to clarify for myself - we're talking about adding a flag to add-ons to prevent them from getting automatically marked as compatible with newer versions of apps?  (I assume separate flags for each app, assuming we start bumping for tb/sm)

Comment 5

[Matthew N. [:MattN]]

(In reply to Wil Clouser [:clouserw] from comment #4)
> Is this bug still valid?

I don't know any reason why it wouldn't be.

> And to clarify for myself - we're talking about adding a flag to add-ons to
> prevent them from getting automatically marked as compatible with newer
> versions of apps?  (I assume separate flags for each app, assuming we start
> bumping for tb/sm)

If the compat. bumps are done using a script, you could just exclude [e-mail] from them for now.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Yes, this is specifically for the hotfix add-on. If this can be a configuration option any developer can set for an add-on, that's better, but not necessary for this bug.

Comment 7

[Takanori MATSUURA]

This bug lies at rest in the graveyard.