Closed
Bug 779395
Opened 11 years ago
Closed 10 years ago
Add support for skew transforms to compositor-driven animations
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: dzbarsky, Assigned: dzbarsky)
References
Details
Attachments
(1 file, 2 obsolete files)
3.99 KB,
patch
|
dbaron
:
review+
akeybl
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #647816 -
Flags: review?(dbaron)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #647816 -
Attachment is obsolete: true
Attachment #647816 -
Flags: review?(dbaron)
Attachment #647820 -
Flags: review?(dbaron)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #647820 -
Attachment is obsolete: true
Attachment #647820 -
Flags: review?(dbaron)
Attachment #653184 -
Flags: review?(dbaron)
Comment 4•11 years ago
|
||
Comment on attachment 653184 [details] [diff] [review] Updated patch r=dbaron, except you should also add tests for the broken things this is fixing. You really need tests for this stuff. If roc, cjones, you, etc., can't figure out a good way to test the whole thing, then you should at the very least write tests that let you test interpolation in the layers code, so that you can test all the value-specific code.
Attachment #653184 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d056bb94292
Comment 6•10 years ago
|
||
Backed out for reftest failures on Android armv7 builds: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=da94e7f02dad&jobname=android.*reftest remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/a22d26116ebe
Assignee | ||
Comment 7•10 years ago
|
||
I couldn't get try to run these tests for some reason. This patch really shouldn't change any android code, so if it fails tests we should try a clobber. https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7722e0d014
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9b7722e0d014
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Assignee | ||
Comment 9•10 years ago
|
||
This patch is very safe and fixes a crash.
blocking-b2g: --- → leo?
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 653184 [details] [diff] [review] Updated patch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): off main thread animations User impact if declined: crashes on skew transform animations (which are very rare) Testing completed: yes Risk to taking this patch (and alternatives if risky): low String or UUID changes made by this patch: none
Attachment #653184 -
Flags: approval-mozilla-b2g18?
Assignee | ||
Updated•10 years ago
|
blocking-b2g: leo? → ---
Comment 11•10 years ago
|
||
Comment on attachment 653184 [details] [diff] [review] Updated patch We don't yet know external crash volume here, so let's be cautious and approve this low risk fix.
Attachment #653184 -
Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Comment 12•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/f5601de16bf0
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-b2g-v1.1hd:
--- → affected
status-firefox22:
--- → wontfix
status-firefox23:
--- → wontfix
status-firefox24:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•