Closed Bug 779395 Opened 8 years ago Closed 7 years ago
Add support for skew transforms to compositor-driven animations
No description provided.
Comment on attachment 653184 [details] [diff] [review] Updated patch r=dbaron, except you should also add tests for the broken things this is fixing. You really need tests for this stuff. If roc, cjones, you, etc., can't figure out a good way to test the whole thing, then you should at the very least write tests that let you test interpolation in the layers code, so that you can test all the value-specific code.
Attachment #653184 - Flags: review?(dbaron) → review+
Backed out for reftest failures on Android armv7 builds: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=da94e7f02dad&jobname=android.*reftest remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/a22d26116ebe
I couldn't get try to run these tests for some reason. This patch really shouldn't change any android code, so if it fails tests we should try a clobber. https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7722e0d014
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
This patch is very safe and fixes a crash.
blocking-b2g: --- → leo?
Comment on attachment 653184 [details] [diff] [review] Updated patch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): off main thread animations User impact if declined: crashes on skew transform animations (which are very rare) Testing completed: yes Risk to taking this patch (and alternatives if risky): low String or UUID changes made by this patch: none
Attachment #653184 - Flags: approval-mozilla-b2g18?
Comment on attachment 653184 [details] [diff] [review] Updated patch We don't yet know external crash volume here, so let's be cautious and approve this low risk fix.
Attachment #653184 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
You need to log in before you can comment on or make changes to this bug.