Closed Bug 779420 Opened 9 years ago Closed 9 years ago

Fix mixed up variable names newVersion/oldVersion in XPIProvider.processPendingFileChanges

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: Unfocused, Assigned: ananuti)

Details

(Whiteboard: [good first bug][mentor=bmcbride@mozilla.com][lang=js][fixed-in-fx-team])

Attachments

(1 file)

XPIProvider.processPendingFileChanges has the variable names newVersion/oldVersion mixed up, here:

http://hg.mozilla.org/mozilla-central/file/99c53832abfe/toolkit/mozapps/extensions/XPIProvider.jsm#l2034

They should be switched (only the variable names - the behaviour is correct.).
Attached patch patchSplinter Review
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Attachment #648237 - Flags: review?(bmcbride)
Comment on attachment 648237 [details] [diff] [review]
patch

Review of attachment 648237 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect - thanks :)
Attachment #648237 - Flags: review?(bmcbride) → review+
Keywords: checkin-needed
Landed on the fx-team branch, which will get merged into mozilla-central within a day or so:
https://hg.mozilla.org/integration/fx-team/rev/b44ee676ced8
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=bmcbride@mozilla.com][lang=js] → [good first bug][mentor=bmcbride@mozilla.com][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b44ee676ced8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.