Closed
Bug 779420
Opened 14 years ago
Closed 14 years ago
Fix mixed up variable names newVersion/oldVersion in XPIProvider.processPendingFileChanges
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: Unfocused, Assigned: ananuti)
Details
(Whiteboard: [good first bug][mentor=bmcbride@mozilla.com][lang=js][fixed-in-fx-team])
Attachments
(1 file)
|
1.78 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
XPIProvider.processPendingFileChanges has the variable names newVersion/oldVersion mixed up, here:
http://hg.mozilla.org/mozilla-central/file/99c53832abfe/toolkit/mozapps/extensions/XPIProvider.jsm#l2034
They should be switched (only the variable names - the behaviour is correct.).
|
Assignee | |
Comment 1•14 years ago
|
||
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 648237 [details] [diff] [review]
patch
Review of attachment 648237 [details] [diff] [review]:
-----------------------------------------------------------------
Perfect - thanks :)
Attachment #648237 -
Flags: review?(bmcbride) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 3•14 years ago
|
||
Landed on the fx-team branch, which will get merged into mozilla-central within a day or so:
https://hg.mozilla.org/integration/fx-team/rev/b44ee676ced8
Keywords: checkin-needed
|
|
Reporter | |
Updated•14 years ago
|
Whiteboard: [good first bug][mentor=bmcbride@mozilla.com][lang=js] → [good first bug][mentor=bmcbride@mozilla.com][lang=js][fixed-in-fx-team]
|
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•