779431 - SRCSRV_ROOT ignored if hg finds a root.

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

I've a mozilla-central clone in one directory, and in a different directory a clone of that first directory - ie, the second directory is an "indirect" clone of mozilla-central.

Running "make buildsymbols" in that second directory rightly complains:

 Could not determine repo info for o:\src\mm\mozilla-hg\mc-socialapi-landing.  This is either not a clone of the web-based repository, or you have not specified SRCSRV_ROOT, or the clone is corrupt.

Fair enough - so I set SRCSRV_ROOT to be the location of mozilla-central but it continues to fail with the same error.

Looking in symbolstore.py, I see that HGFileInfo.__init__ first attempts to use 'hg' to find the root, and only if that fails does SRCSRV_ROOT get looked at.  In my scenario, hg does correctly provide the root (pointing at the other directory), so SRCSRC_ROOT doesn't get looked at.  It probably should trust SRCSRV_ROOT if it is set and only ask hg if it is not.

Comment 1

[(not currently active) Ted Mielczarek]

Seems pretty reasonable.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: if SRCSRV_ROOT is set, don't bother asking hg for the path

This patch fixes things for me.  Not sure who could review this though...

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/6afd61ba31de

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6afd61ba31de