Closed
Bug 779468
Opened 12 years ago
Closed 12 years ago
Add halfmoon compilation and testing to the sandbox and tamarin-redux
Categories
(Tamarin Graveyard :: Build Config, defect)
Tamarin Graveyard
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: brbaker, Assigned: dschaffe)
References
Details
Attachments
(2 files)
21.02 KB,
patch
|
dschaffe
:
review+
|
Details | Diff | Splinter Review |
5.57 KB,
text/plain
|
Details |
Currently halfmoon is only compiled and tested in the deep phase of the Jenkins build system and is NOT tested in the sandbox builder. Since halfmoon is going to be a first class citizen it must be built and tested on all changes, not just on deep phase builds.
Reporter | ||
Comment 1•12 years ago
|
||
Attachment #647919 -
Flags: review?(dschaffe)
Assignee | ||
Updated•12 years ago
|
Attachment #647919 -
Flags: review?(dschaffe) → review+
General question/comment. Are there really separate build scripts for each build target? Is there no way to consolidate into a single script that supports all platforms? We can sparingly use platform checks only where absolutely unavoidable. I assume on Windows we run the script on some Unix shell variant such as cygwin/mks. I have not looked at the full script, but gnumake is pretty cross platform friendly if we can convert into a Makefile instead. To have separate scripts seems like a maintenance nightmare.
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to jmelvin from comment #2) > General question/comment. Are there really separate build scripts for each > build target? Is there no way to consolidate into a single script that > supports all platforms? We can sparingly use platform checks only where > absolutely unavoidable. I assume on Windows we run the script on some Unix > shell variant such as cygwin/mks. I have not looked at the full script, but > gnumake is pretty cross platform friendly if we can convert into a Makefile > instead. To have separate scripts seems like a maintenance nightmare. Not sure what this comment is towards but yes we do use gnu make to drive all compilation on all platforms. The patch that is in here is Jenkins driving scripts.
Reporter | ||
Comment 4•12 years ago
|
||
blocks of code that can be pasted into the "tamarin-redux", "sandbox" and "sandbox-p4" jenkins compilation jobs. Dan I am setting you as a reviewer, but really I am just setting this to remind you to enable the compilation once it is working on all platforms.
Attachment #648703 -
Flags: review?(dschaffe)
Reporter | ||
Comment 5•12 years ago
|
||
Dan can you add the compilation blocks to Jenkins once the code fixes in bug# 750694 have landed.
Assignee: nobody → dschaffe
Status: NEW → ASSIGNED
Reporter | ||
Comment 6•12 years ago
|
||
Building halfmoon release and debug in all Jenkins projects at the moment. Closing bug.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•