779502 - indexing doesn't work *at all* if ES_LIVE_INDEXING is False

Status: RESOLVED FIXED

(support.mozilla.org :: Search, defect)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Indexing doesn't work *at all* if ES_LIVE_INDEXING is False. Further, it's subtle about it. So you can have:

    ES_LIVE_INDEXING = False

in your settings file and then do:

    $ ./manage.py esreindex

and it'll go through all the motions of indexing, but when you do:

    $ ./manage.py esstatus

it shows nothing in the index.

ES_LIVE_INDEXING setting affects whether kitsune kicks off indexing tasks from post_save hooks on various models. It should NOT affect indexing from the admin or command line.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

It's an easy fix for the command line. I think I'm going to do this:

1. fix it for the command line (should be easy--i'll abuse override_settings)

2. add a note to the admin about it something like, "YO, FOOL: ES_LIVE_INDEXING IS THE FALSE! YOU NOT BE DOING INDEXING WITH THAT, YO!"

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a pull request: https://github.com/mozilla/kitsune/pull/1050

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/kitsune/commit/02ff0b30d64c2ba509d4e512108b5a27ea41a4c5

This doesn't affect -dev, -stage or -prod since ES_LIVE_INDEXING is True in all three of those environments. Therefore, I'm going to mark this as FIXED now.