779616 - Stop using DOMAttrModified events

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[[e-mail]]

Instead we should use the new HTML5 mutation observers.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Philip Chee]

Thu Aug 02 2012 23:00:23
Warning: Use of Mutation Events is deprecated. Use MutationObserver instead.
Source file: chrome://navigator/content/navigator.xul

Comment 3

[Philip Chee]

Ignore that. Extension problem.

Comment 4

[Ian Neal]

Comment on attachment 648059 [details] [diff] [review]
Proposed patch

>+function AddMutationObserver(callback)
> {
>+  new MutationObserver(callback).observe(callback(), {attributes: true, attributeFilter: ["hidden"]});
> }
> 
>+function UpdateFolderUnreadCol()
> {
>+  var folderUnreadCol = document.getElementById("folderUnreadCol");
>+  var hidden = folderUnreadCol.getAttribute("hidden");
>+  var folderNameCell = document.getElementById("folderNameCell");
>+  var label = {true: "?folderTreeName", false: "?folderTreeSimpleName"};
>+  folderNameCell.setAttribute("label", label[folderUnreadCol.hidden]);
Do you really mean folderUnreadCol.hidden here or just hidden? Either there is an unused variable or the above line needs fixing.

r=me with that fixed.

Comment 5

[[e-mail]]

(In reply to Ian Neal from comment #4)
>(From update of attachment 648059 [details] [diff] [review])
>>+  var folderUnreadCol = document.getElementById("folderUnreadCol");
>>+  var hidden = folderUnreadCol.getAttribute("hidden");
>>+  var folderNameCell = document.getElementById("folderNameCell");
>>+  var label = {true: "?folderTreeName", false: "?folderTreeSimpleName"};
>>+  folderNameCell.setAttribute("label", label[folderUnreadCol.hidden]);
>Do you really mean folderUnreadCol.hidden here or just hidden? Either there
>is an unused variable or the above line needs fixing.
Yeah, hidden is redundant, thanks for catching that.

Comment 6

[Philip Chee]

(Don't you need a moa from Karsten at least?)
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/423cb0440fca

Comment 7

[Karsten Düsterloh]

Comment on attachment 648059 [details] [diff] [review]
Proposed patch

>+function AddMutationObserver(callback)

I would have preferred "aCallback" …

Comment 8

[[e-mail]]

I guess this is fixed, as bm-props.js should have its own bug.