Closed Bug 779625 Opened 7 years ago Closed 10 months ago

Send telemetry metric when exceptions are thrown.

Categories

(Tamarin Graveyard :: Profiler, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: gcomnino, Unassigned)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_0) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.57 Safari/537.1

Steps to reproduce:

We should send a metric for thrown exceptions. It should include the exception type (i.e. class) and the stack trace. Many users have asked for the ability to get the stack trace in release builds when exceptions are thrown.
Attached patch for: 1) add method for dumping the MethodFrame stack to a string, and 2) send a telemetry metric for thrown exceptions with the error class and stack trace.
Attachment #648069 - Flags: superreview?(fklockii)
Attachment #648069 - Flags: review?(rulohani)
Comment on attachment 648069 [details] [diff] [review]
Send metric for thrown exceptions with stack trace

Review of attachment 648069 [details] [diff] [review]:
-----------------------------------------------------------------

::: //depot/main/FlashRuntime/Main/code/third_party/avmplus/core/AvmCore.cpp
@@ +1656,5 @@
> +                // get the full class name including the namespace
> +                so->traits()->print(exceptionStringBuffer, true);
> +            } else {
> +                // backup, just convert atom to a string, it will say "Error"
> +                exceptionStringBuffer << StUTF8String(string(exception->atom)).c_str();

I did not fully understand the comment regarding "Error".
Attachment #648069 - Flags: review?(rulohani) → review+
Attachment #648069 - Flags: superreview?(fklockii) → superreview+
The comment just means it will say just "Error" for the exception class instead of something more useful like "flash.errors::IOError". Interestingly "Error" is all the exception dialog in debugger builds says. I don't actually know of any cases where it would get into the backup code anyway.
changeset: 7528:cbe55af57d88
user:      Dan Schaffer <Dan.Schaffer@adobe.com>
summary:      Bug 779625: Send telemetry metric when exceptions are thrown. (p=gcomnino,r=fklockii,r=rulohani)

http://hg.mozilla.org/tamarin-redux/rev/cbe55af57d88
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
Status: UNCONFIRMED → RESOLVED
Closed: 10 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.