779664 - moztest needs tests

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

oh the irony.  moztest needs some tests for its results and output
capabilities.  A good first round should mostly be tests illustrating
the API and smoke-testing it

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: some first tests + required mods

I had to improve some of the code in results.py, thanks to the tests.

Comment 2

[Jeff Hammel]

Comment on attachment 648570 [details] [diff] [review]
some first tests + required mods

Its great to see tests!  You'll also need to make a manifest for it (see the other tests directories) and add this to the root test-manifest.ini.  Other than that, looks good.

+           self.hostname == other.hostname and
+           self.arch == other.arch and
+           self.env == other.env and
+           self.os == other.os and
+           self.os_version == other.os_version

I'd rather see a TestContext class variable, e.g. `keys` with these values and then a comparison e.g

isinstance(other, TestContext) and not [i for i in keys if getattr(self, i) == getattr(other, i)]

This way, one can add keys without having to change in multiple places.  I'm not sure how to fix hash exactly, but maybe

attrs = [getattr(self, i) for i in self.keys]
return hash(tuple([(isinstance(i, dict) and tuple(i.items()) or i) for i in attrs]))

Not wonderful, but I'm not sure if there is a standard way to hash standard mutable types in python, though if we need it it can be done

+        self.assertTrue(math.fabs(duration - t.duration) < 1)

Good enough, I guess.

Comment 3

[Jeff Hammel]

sorry, meant:

not [i for i in keys if getattr(self, i) != getattr(other, i)]

Oh boolean logic!

Comment 4

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: fix according to feedback

Comment 5

[Jeff Hammel]

Comment on attachment 648790 [details] [diff] [review]
fix according to feedback

Looks good to me!

Comment 6

[Mihnea Dobrescu-Balaur (:mihneadb)]

https://github.com/mozilla/mozbase/commit/314213e674dce74be27701b8cf4194f36d0ac020
https://github.com/mozilla/mozbase/commit/9c285755cd1ff427029e10a3f3f1f3625832aa73