77969 - ftp(HTML) - HTML correctness

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[tenthumbs]

There's no <pre> tag but there is a </pre> tag at the end of the file so the
listing is in a proportional font. Not a big deal, though.

Comment 1

[Doug Turner (:dougt)]

sr=darin.
fix checked in.

Comment 2

[tenthumbs]

With an 0428 build, tidy gets upset because the entire table is wrapped
inside the <pre> tag. I guess the "right" thing is to use css; something
like:

  <head>
     ...
    <style type="text/css">
      TD {font-family: monospace; }
    </style>
  </head>

although the family may well be wrong.

You're all going to hate me but I'm going to reopen this bug. Sorry.

Comment 3

[Doug Turner (:dougt)]

reassigning to [e-mail].

Comment 4

[Bradley Baetz (:bbaetz)]

My dirviewer rewrite doesn't help this, but there's no point in changing it
until that semi-rewrite lands.

Comment 5

[benc]

clarified summary + qawanted - my layout skills are limited. perhaps someone can 
qa the final change for correctness?

Comment 6

[basic]

with CSS this should be easy.
bbaetz: if you don't mind, I'd like to try fix this.

Comment 7

[Bradley Baetz (:bbaetz)]

Feel free.

Comment 8

[basic]

before I do any 

Comment 9

[basic]

oops!

Is there any preference as to use <style> </style> in <head> to style the page
or inline style="" to style individual elements? The difference is that if
style="" is used, the style will get copied when a copy/paste operation is done,
where as using <style></style> will not.

Comment 10

[Bradley Baetz (:bbaetz)]

Use an external style sheet with a resource: url, so that it can be themed.

Comment 11

[basic]

Attachment: mockup

here is a mockup of what I intend to do. Do take a look at the HTML source.
Would like some feedback.

Comment 12

[basic]

assigning to nobody

Comment 13

[benc]

should this go back to bbaetz?

Comment 14

[benc]

There was an FTP/HTML re-write that I verified this weekend. Can someone who is
layout-smart look at the newer HTML source, and update this bug w/ a list of
things that need to be changed?

Comment 15

[lohphat]

Test URL: http://ftp.mozilla.org/pub/mozilla/nightly/latest/
HTML of FTP directory listings still horked. win32 2002101508:

HTML:
[   ] mozilla-win32-instal..> 16-Oct-2002 10:09  10.7M  
[   ] mozilla-win32-instal..> 16-Oct-2002 10:05   214k  
[   ] mozilla-win32-talkba..>                        -  
[   ] mozilla-win32.zip                              -  

FTP:
File: mozilla-win32-installer-sea.exe  10963 KB 10/16/2002 10:09:00
File: mozilla-win32-installer.exe        215 KB 10/16/2002 10:05:00
File: mozilla-win32-talkback.zip       10982 KB 10/16/2002 10:08:00
File: mozilla-win32.zip                10742 KB 10/16/2002 10:06:00

Comment 16

[basic]

The HTML validates for some time already, I just tested to make sure (with
1.4beta). As for comment 15, this is about the html generated by the browser not
the web server. Try ftp://ftp.mozilla.org/pub/mozilla/nightly/latest/

Comment 17

[benc]

VERIFIED/fixed: thanks, basic.