Add support for Harmony modules to TokenStream

RESOLVED FIXED in mozilla18

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ejpbruel, Assigned: ejpbruel)

Tracking

unspecified
mozilla18
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
As a first step towards implementing Harmony modules, several reserved keywords (i.e. export/import), have to be turned into real keywords.
(Assignee)

Comment 1

6 years ago
Created attachment 648312 [details] [diff] [review]
Patch to be reviewed
Attachment #648312 - Flags: review?(jorendorff)

Comment 2

6 years ago
Presumably this doesn't block bug 568593 :)
No longer blocks: 568593

Updated

6 years ago
Blocks: 779810
Comment on attachment 648312 [details] [diff] [review]
Patch to be reviewed

We haven't been consistently making new JS_HAS_* feature macros for some time, because they're not all that useful.

There aren't any for default parameters, rest params, or for-of, for example; no one has complained.

So I'm in favor of ditching JS_HAS_MODULES. Your call, though.
Attachment #648312 - Flags: review?(jorendorff) → review+
Whiteboard: [js:p2]
Whiteboard: [js:p2] → [js:t]

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/94d4f04bb326
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.