779799 - Add support to call Bugzilla::Version->check({ id => $id })

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Koosha KM]

Attachment: patch

Comment 1

[Koosha KM]

Attachment: patch

Comment 2

[Frédéric Buclin]

Comment on attachment 648309 [details] [diff] [review]
patch

>-    my $version = new Bugzilla::Version({ name => $name, product => $product });
>+    my $version = new Bugzilla::Version({ name => 'version_name', product => $product_obj });

There is no reason to replace $name by 'version_name'. We do it everything else and that's fine. Please revert this change.
About making clearer that you need a product object instead of a product name, this change is helpful and can stay.


>+    my $version = Bugzilla::Version->check({ name => 'version_name', product => $product_obj });

Use $name instead of 'version_name'.


>+    my $version = Bugzilla::Version->check({ id => $id });

Our policy is to only implement stuff if we use it, and actually, your patch implements the ability to pass {id => $id}, but this is used nowhere. Is there a place where you plan to use it? If yes, please mark this bug as blocking the bug which would use it. Else I see no reason to take this change.


>-        { value => $name, product => $product });
>+        { value => 'name', product => $product_obj });

Same comment as above. $product_obj is clearer, but there is no reason to replace $name by 'name'.

Comment 3

[Koosha KM]

Attachment: patch

Comment 4

[Frédéric Buclin]

Comment on attachment 653153 [details] [diff] [review]
patch

r=LpSolit

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Version.pm
Committed revision 8383.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified Bugzilla/Version.pm
Committed revision 8381.