Hook libxpnet's pause/resume support into the windows installer

VERIFIED FIXED

Status

SeaMonkey
Installer
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: Samir Gehani, Assigned: Sean Su)

Tracking

Trunk
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
 
(Reporter)

Comment 1

17 years ago
Marking nsbeta1+ per discussion in XPInstall meeting about spawning this bug 
from bug 67247.
Keywords: nsbeta1+
(Assignee)

Comment 2

17 years ago
Created attachment 33636 [details] [diff] [review]
patch #1 (ns tree)
(Assignee)

Comment 3

17 years ago
Created attachment 33637 [details] [diff] [review]
patch #1 (moz tree)
(Assignee)

Comment 4

17 years ago
the above patches will fix the following bugs:
  http://bugzilla.mozilla.org/show_bug.cgi?id=77244 - Installers need to create 
Win32 Reg. key schema that Gecko Embedding browsers can follow 
  http://bugzilla.mozilla.org/show_bug.cgi?id=64567 - Unable to see which build 
is being installed by installer (fix only for mozilla)
  http://bugzilla.mozilla.org/show_bug.cgi?id=64567 - Unable to see which build 
is being installed by installer
  http://bugzilla.mozilla.org/show_bug.cgi?id=75655 - FTP vs. HTTP Downloading
  http://bugzilla.mozilla.org/show_bug.cgi?id=78449 - Add config.ini key to 
disable the Site Selector menu.
  http://bugzilla.mozilla.org/show_bug.cgi?id=79173 - The string get cut-off in 
"Start Install"

Puts a temporary workaround for bug:
  http://bugzilla.mozilla.org/show_bug.cgi?id=77179 - Download hangs on Win98 
machine over Cable/DSL through SERA

  http://bugscape/show_bug.cgi?id=4886
Status: NEW → ASSIGNED
What's WIZ_xpinstallVersion used for? "6.5.1" for the commercial product is 
wrong, that would indicate "Netscape 6.51" which we're fairly likely to ship 
someday. The version registry version would be 6.5.0.<builddate>.  Sorry I 
didn't catch this in the previous review. "0.9.1" for moz is ok since that's 
what we're shipping next (but it, too, should have the builddate tacked on).

As sent in mail, I'd like a comment in SetStatusStatus() about why you're using 
the seemingly less accurate rounded rate for the time-left calculation. Your 
explanation about keeping the time-left value from jumping around was great, 
but put a comment in the code to keep people like me from "fixing" this in the 
future.

r=dveditz

Comment 6

17 years ago
i'm good for a rubber stamp sr=mscott
(Assignee)

Comment 7

17 years ago
yay, it's checked in!
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
Netscape 6 Installer - has pause/resume!!
build 2001051104
Status: RESOLVED → VERIFIED
QA Contact: gemal → gbush
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.