77982 - A table cell containing an image may not show the cell's border and/or padding

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P3)

Description

[karnaze (gone)]

If a table cell contains an image and the cell's width and/or heigth is 
determined by the image, the cell's full border and padding will likely not be 
shown. For a 1 pixel border and 1 pixel paddding this will mean that the padding 
is not shown. Attachment #1 [details] [diff] shows a more severe example.

Comment 1

[karnaze (gone)]

Attachment: test case

Comment 2

[karnaze (gone)]

Attachment: correct test case (ignore previous one)

Comment 3

[karnaze (gone)]

Moving to m0.9.1. The image must not be in the cache to see the bug. This bug 
was discovered after looking at the test case in bug 14929.

Comment 4

[karnaze (gone)]

Attachment: patch to fix the bug

Comment 5

[Bernd]

Chris, I tried your patch. As a first step I downloaded the testcase to my local 
disc as the lxr gif access does not work and adjusted the image src path. Then I 
started the viewer and as the table is larger then 600px I hit the maximise 
button and could eyewitness the next reflow bug. You should fix this as well 
within this patch :-).

Comment 6

[Bernd]

Attachment: screenshot of the maximize problem

Comment 7

[karnaze (gone)]

Moving m0.9.3

Comment 8

[Blake Ross]

Missed 0.9.3.

Comment 9

[Greg Breland]

I can reproduce this on Linux, so marking OS->All

To Reproduce, using Mozilla on Linux, go to: 
http://gbreland.one-arm.com/mozilla/jump.html

Page will appear correctly.  Now click on <reload> and the problem will show
itself.  I used style="border-width:15px;" to make the problem obvious.

Comment 10

[karnaze (gone)]

reassigning to m0.9.6

Comment 11

[Greg Breland]

Actually, you need to do a <shift><reload> with my example at:

  http://gbreland.one-arm.com/mozilla/jump.html

This is a big problem as can be seen with my other site.  Notice how the logo
bounes up and down when <reload> and <shift><reload>

  http://www.mozillanews.org/

Comment 12

[karnaze (gone)]

Comment on attachment 32485 [details] [diff] [review]
patch to fix the bug

sr=attinasi, r=alexsavulov

Comment 13

[karnaze (gone)]

Bernd, I can't reproduce the problem you were having. I first tried 
putting the image locally and then changed the test case to access the image 
from mozilla.org to get more of a time delay.

Comment 14

[karnaze (gone)]

Attachment: same patch made from a more current tree

Comment 15

[karnaze (gone)]

The patch is in.