Last Comment Bug 779865 - CompileOptions needs to be marked JS_PUBLIC_API
: CompileOptions needs to be marked JS_PUBLIC_API
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: :Benjamin Peterson
:
Mentors:
Depends on:
Blocks: 779724
  Show dependency treegraph
 
Reported: 2012-08-02 08:44 PDT by :Benjamin Peterson
Modified: 2012-08-02 19:07 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
make CompileOptions public (744 bytes, patch)
2012-08-02 08:46 PDT, :Benjamin Peterson
jimb: review+
Details | Diff | Review

Description :Benjamin Peterson 2012-08-02 08:44:04 PDT
Otherwise it doesn't get exported in shared libraries leading to sad faces.
Comment 1 :Benjamin Peterson 2012-08-02 08:46:06 PDT
Created attachment 648356 [details] [diff] [review]
make CompileOptions public
Comment 2 Jim Blandy :jimb 2012-08-02 14:03:45 PDT
Comment on attachment 648356 [details] [diff] [review]
make CompileOptions public

Review of attachment 648356 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Sorry I missed this.
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-02 19:07:42 PDT
https://hg.mozilla.org/mozilla-central/rev/400ef849f6d8

Note You need to log in before you can comment on or make changes to this bug.