Last Comment Bug 779935 - nsIAppsService.idl need to get mozIDOMApplication from manifest id
: nsIAppsService.idl need to get mozIDOMApplication from manifest id
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: [:fabrice] Fabrice Desré
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 746280 777135
  Show dependency treegraph
 
Reported: 2012-08-02 11:04 PDT by Doug Turner (:dougt)
Modified: 2012-08-08 18:25 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.92 KB, patch)
2012-08-06 11:31 PDT, [:fabrice] Fabrice Desré
mounir: review+
Details | Diff | Splinter Review
patch v2 (5.61 KB, patch)
2012-08-07 16:04 PDT, [:fabrice] Fabrice Desré
mounir: review+
Details | Diff | Splinter Review

Description Doug Turner (:dougt) 2012-08-02 11:04:27 PDT
We need the ablity to go from a manifest id (which is part of the nsIPrincipal) to a mozIDOMApplication.  The current methods on nsIAppsService only accept manifest urls.
Comment 1 [:fabrice] Fabrice Desré 2012-08-02 11:17:42 PDT
How are these ids created?
Comment 2 Mounir Lamouri (:mounir) 2012-08-05 15:42:03 PDT
(In reply to Fabrice Desré [:fabrice] from comment #1)
> How are these ids created?

This is |localId| I believe.
Comment 3 [:fabrice] Fabrice Desré 2012-08-06 11:31:03 PDT
Created attachment 649330 [details] [diff] [review]
patch
Comment 4 Mounir Lamouri (:mounir) 2012-08-07 15:12:55 PDT
Comment on attachment 649330 [details] [diff] [review]
patch

Review of attachment 649330 [details] [diff] [review]:
-----------------------------------------------------------------

Could you add a method that also returns the manifest URL from the localId? I believe some consumers only need that.
Comment 5 [:fabrice] Fabrice Desré 2012-08-07 16:04:55 PDT
Created attachment 649854 [details] [diff] [review]
patch v2

Updated to add a |getManifestURLByLocalId(id)| method.
Comment 6 Mounir Lamouri (:mounir) 2012-08-08 09:14:44 PDT
Comment on attachment 649854 [details] [diff] [review]
patch v2

Review of attachment 649854 [details] [diff] [review]:
-----------------------------------------------------------------

Can you push this ASAP so dependencies don't get blocked for too long.
Comment 7 [:fabrice] Fabrice Desré 2012-08-08 10:16:26 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a137b39297de
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-08-08 18:25:28 PDT
https://hg.mozilla.org/mozilla-central/rev/a137b39297de

Note You need to log in before you can comment on or make changes to this bug.