779936 - Aug 2 nightly busted on Galaxy S2 & S3

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

UI comes up, but no pages ever load -- almost as if Gecko doesn't finish coming up.  If opened via a URL in an intent, content area stays black; but throbber in url bar just keeps going forever.  Nothing interesting in logs.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

2012-08-02 Loads on my Galaxy Nexus. Anything interesting in logcat or via debugging?

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Nope, nothing.  Works fine for me on Galaxy Nexus, HTC One X, and Nexus 7 (modulo the allocatedirect assertion exception).

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This was broken by bug 779152 -- the compositor thread is blocked in GLController.waitForValidSurface on startup.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

So we're hitting an error from TextureView:

W/TextureView( 5168): A TextureView or a subclass can only be used with hardware acceleration enabled.

It seems to be disabled (by default?) on this Adreno-based S3, and we're not forcing anything via our manifest (via android:hardwareAccelerated="true" in our <application> or activity, or at the window level.

Working on a patch.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix

This adds the hardwareAccelerated flag to our manifest, and also checks to make sure that we actually are hardware accelerated before using a TextureView.

snorp says this should get a qa look especially on Honeycomb devices, because of different hardwareAccelerated interactions there.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af61b4b10e3a

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/af61b4b10e3a

Comment 8

[Ed Morley [:emorley]]

Doh, wish I'd seen this before I cleared my profile in the hope it would fix things on my S2 :-(
(Comment 7 was posted by a script)

If you ever need fixes released more urgently - the sheriffs will happily retrigger Nightlies for you (and we can double land directly onto mozilla-central if needs be) if that helps for the future? :-)