Closed
Bug 779944
Opened 12 years ago
Closed 12 years ago
Jenkins compile script can fail to validate shell features
Categories
(Tamarin Graveyard :: Tools, defect)
Tamarin Graveyard
Tools
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: brbaker, Unassigned)
Details
Attachments
(1 file)
2.74 KB,
patch
|
dschaffe
:
review+
|
Details | Diff | Splinter Review |
If we can't execute the compiled shell natively, skip the feature validation. Background: A feature of the compile-generic.sh script that the build system uses is that it can validate avm features and tweaks that are reported via the -Dversion switch. This works fine if the generated binary is native to the host platform but fails when the binary is actually being cross compiled. In the past this wasn't an issue as we had separate invocations of the script for the various platforms and we would make sure that we did not validate features for android, arm-linux etc. However with the move to jenkins we have consolidated all of the calls for all platforms, so now we are trying to validate features when we are unable to actually execute the shell natively.
Reporter | ||
Comment 1•12 years ago
|
||
Attachment #648414 -
Flags: review?(dschaffe)
Updated•12 years ago
|
Attachment #648414 -
Flags: review?(dschaffe) → review+
Comment 2•12 years ago
|
||
changeset: 7519:38d673ef94d4 user: Brent Baker <brbaker@adobe.com> summary: Bug 779944 - Jenkins compile script can fail to validate shell features (r=dschaffe) http://hg.mozilla.org/tamarin-redux/rev/38d673ef94d4
Reporter | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•