779979 - mozharness should be more explicit about why it can't accept a configuration file with wrong extension

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[William Lachance (:wlach)]

When I try to make a mozharness script use a file which does not end in .json or .py, I currently get the following confusing error:

python scripts/device_talosrunner.py --cfg remotetalos.json
Traceback (most recent call last):
  File "scripts/device_talosrunner.py", line 206, in <module>
    device_talos_runner = DeviceTalosRunner()
  File "scripts/device_talosrunner.py", line 62, in __init__
    require_config_file=require_config_file,
  File "/home/wlach/src/mozharness/mozharness/mozilla/testing/talos.py", line 89, in __init__
    BaseScript.__init__(self, **kwargs)
  File "/home/wlach/src/mozharness/mozharness/base/script.py", line 545, in __init__
    **kwargs)
  File "/home/wlach/src/mozharness/mozharness/base/config.py", line 180, in __init__
    self.parse_args()
  File "/home/wlach/src/mozharness/mozharness/base/config.py", line 330, in parse_args
    self.set_config(parse_config_file(options.config_file))
  File "/home/wlach/src/mozharness/mozharness/base/config.py", line 137, in parse_config_file
    raise RuntimeError, "Unknown config file type %s!" % file_name
Unknown config file type 'talos.config'!

At the least, we could specify what types of files ARE valid (i.e. those ending in .json or .py)

Comment 1

[William Lachance (:wlach)]

Attachment: Simple patch to improve error message

Simple patch with improved error message

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 648477 [details] [diff] [review]
Simple patch to improve error message

I'd love to fix parse_config_file, but haven't figured out how yet.
This'll help.

Comment 3

[Aki Sasaki (not active)]

Will: did you want to check this in?  Want me to?

Comment 4

[William Lachance (:wlach)]

Attachment: Bug 779979 - Be more explicit about why mozharness can't accept a config file with wrong extension

Review commit: https://reviewboard.mozilla.org/r/130058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130058/

Comment 5

[William Lachance (:wlach)]

Comment on attachment 648477 [details] [diff] [review]
Simple patch to improve error message

Better late than never? Hopefully autoland/mozreview will make sure it actually gets in this time.

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 8858074 [details]
Bug 779979 - Be more explicit about why mozharness can't accept a config file with wrong extension

https://reviewboard.mozilla.org/r/130058/#review132644

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fccdd8de0ae
Be more explicit about why mozharness can't accept a config file with wrong extension r=aki

Comment 8

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/5fccdd8de0ae