779999 - [traceback] Error extracting files.utils.is_valid

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P1)

Description

[Christopher Van Wiemeersch [:cvan]]

45,000 tracebacks!

http://sentry.dmz.phx1.mozilla.com/addons/group/1629/

Error extracting

Stacktrace (most recent call last):

  File "files/utils.py", line 255, in is_valid
    zip = zipfile.ZipFile(self.source, self.mode)

  File "python/zipfile.py", line 680, in __init__
    self.fp = open(file, modeDict[mode])

Comment 1

[Andy McKay]

Note that I grouped the errors together so that instead of getting one group in sentry per addon, they now all get grouped together. It's not one specific addon, but occurring on a whole pile of addons.

https://github.com/mozilla/zamboni/commit/b5e3851f

Comment 2

[Wil Clouser [:clouserw]]

If they're bad zip files, there isn't a lot we can do (and we shouldn't be raising an error).  If we logged filenames we could see if there was a pattern though.  I guess we're already logging which users are trying this so we could correlate that way too.

Comment 3

[Jeremy Orem [:oremj]]

This isn't an actual crash traceback. log.error goes to Sentry as well and this is coming from https://github.com/mozilla/zamboni/blob/master/apps/files/utils.py#L258

I assume whatever is calling is_valid catches the raised exception otherwise the actual traceback would be there as well.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

We're up to 296,000 tracebacks: http://sentry.dmz.phx1.mozilla.com/addons/group/1629/

Comment 5

[Andy McKay]

Since we don't seem too worried about fixing this, how about we just change log.error to log.info?

Comment 6

[Wil Clouser [:clouserw]]

(In reply to Andy McKay [:andym] from comment #5)
> Since we don't seem too worried about fixing this, how about we just change
> log.error to log.info?

Sounds good to me

Comment 7

[Andy McKay]

https://github.com/mozilla/zamboni/commit/594313