German / de locale is falling back to /en-US, for mobile

VERIFIED FIXED

Status

--
critical
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: stephend, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fromAutomation])

http://qa-selenium.mv.mozilla.com:8080/job/mozilla.com.trunk/2253/testReport/tests.test_redirect_landing/TestRedirectLanding/test_redirect_locale_mobile/ [1] is now failing:

Stacktrace

self = <tests.test_redirect_landing.TestRedirectLanding object at 0x107e27190>
mozwebqa = <pytest_mozwebqa.pytest_mozwebqa.TestSetup instance at 0x107e12320>

    @pytest.mark.nondestructive
    def test_redirect_locale_mobile(self, mozwebqa):
        headers = {}
        headers.update(self.MOBILE)
        self._test_one_redirect(mozwebqa, '/de/firefox/', '/de/m/',
>           headers)

tests/test_redirect_landing.py:98: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <tests.test_redirect_landing.TestRedirectLanding object at 0x107e27190>
mozwebqa = <pytest_mozwebqa.pytest_mozwebqa.TestSetup instance at 0x107e12320>
origin = '/de/firefox/', final = '/de/m/'
headers = {'User-Agent': 'Mozilla/5.0 (Linux; U; Android 4.0.3; de-ch; HTC Sensation Build/IML74K) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30'}

    def _test_one_redirect(self, mozwebqa, origin, final, headers):
        url = mozwebqa.base_url + origin
        response = requests.get(url, headers=headers)
        result = mozwebqa.base_url + final
>       Assert.equal(result, response.url)

tests/test_redirect_landing.py:24: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <class unittestzero.Assert at 0x107abfae0>
first = 'https://www-dev.allizom.org/de/m/'
second = u'https://www-dev.allizom.org/en-US/mobile/', msg = None

    @classmethod
    def equal(self, first, second, msg=None):
>       assert first == second, msg
E       assert 'https://www-...zom.org/de/m/' == u'https://www-...en-US/mobile/'
E         - https://www-dev.allizom.org/de/m/
E         ?                             ^  --
E         + https://www-dev.allizom.org/en-US/mobile/
E         ?                             ^^^^^^^^^^^

.env/lib/python2.7/site-packages/unittestzero.py:45: AssertionError

[1] https://github.com/mozilla/mcom-tests/blob/master/tests/test_redirect_landing.py
So Pascal changed those as part in r107968, r107976. We'll have to change the tests so that they check the right page now. But also change the redirect because it does multiple requests.
Fixed in r108007. It also fixes more cases with prefetch.php.
Pushed to stage with r108008 and production with r108009.

Test fixage in https://github.com/mozilla/mcom-tests/pull/70
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Verified FIXED; thanks!
Status: RESOLVED → VERIFIED
(Assignee)

Updated

6 years ago
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.