Closed Bug 780121 Opened 8 years ago Closed 8 years ago

Expose internal Add-ons Manager objects in debug builds

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: Unfocused, Assigned: Unfocused)

Details

Attachments

(1 file)

I've had a basic version of part of this in my patch queue for awhile, and found it really useful when debugging stuff: It adds the following properties which map to their respective internal objects:

* AddonWrapper.__AddonInternal__
* AddonInstallWrapper.__AddonInstallInternal__
* AddonManager.__AddonManagerInternal__

This happens in either debug builds or when a MOZ_EM_DEBUG environment variable is set when building (since I almost never use debug builds).

The names are just awkward enough to use that they won't accidentally be used. And only exposing them in special builds, rather than based on a preference, means they can't be abused (by, for instance, add-ons).
Attached patch Patch v1Splinter Review
Attachment #648671 - Flags: review?(dtownsend+bugmail)
Comment on attachment 648671 [details] [diff] [review]
Patch v1

Review of attachment 648671 [details] [diff] [review]:
-----------------------------------------------------------------

This is agreeable to me
Attachment #648671 - Flags: review?(dtownsend+bugmail) → review+
https://hg.mozilla.org/mozilla-central/rev/320b8cd5c893
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.