Closed Bug 78014 Opened 24 years ago Closed 24 years ago

areTheSameFileNames leaks

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbaron, Assigned: hwaara)

Details

(Keywords: memory-leak)

Attachments

(1 file)

On the mozilla 0.9 branch, running under the Boehm GC, I see that areTheSameFileNames leaks. This happens on startup. |GetLeafName| copies, so you have to free the buffer. Probably the easiest way to do that is by using nsXPIDLCString. http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/modules/plugin/nglsrc/nsPluginHostImpl.cpp&rev=1.233&mark=3414#3404
Status: NEW → ASSIGNED
Taking. I've got a fix coming up
Assignee: av → hwaara
Status: ASSIGNED → NEW
Attached patch fixSplinter Review
r=bbaetz
Looks safe. ra=av
AV, ra=?
is module owner approval and r= sufficent for checkin, or do I need to bring in another sr=?
sr= is still needed. Changing platform to all.
OS: Linux → All
Hardware: PC → All
sr=blizzard
fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
marking verified (rubberstamp)
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: