Closed Bug 780161 Opened 8 years ago Closed 8 years ago

Improve nsGlobalWindow APIs for indexed properties a bit

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(3 files)

No description provided.
Attachment #648706 - Flags: review?(peterv)
Attachment #648707 - Flags: review?(peterv)
Attachment #648708 - Flags: review?(peterv)
Comment on attachment 648706 [details] [diff] [review]
Part a: Deduplicate code in nsDOMWindowList

Review of attachment 648706 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDOMWindowList.cpp
@@ +58,5 @@
> +
> +    nsCOMPtr<nsIDocument> doc = do_QueryInterface(domdoc);
> +
> +    if (doc) {
> +      // Note: this flush may cause mDocShellNode to become null.

I think this needs to be called out in the declaration too, since it's the callers that need to deal with it.
Attachment #648706 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/0c4d6f6f8286
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
There's still work for Peter here...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 648707 [details] [diff] [review]
Part b: GetLength()

This is ok, but long-term we just want to get rid of this windowlist thing...
Attachment #648707 - Flags: review?(peterv) → review+
Comment on attachment 648708 [details] [diff] [review]
Part c: IndexedGetter

r=me
Attachment #648708 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/ca3c9d6c410a
https://hg.mozilla.org/mozilla-central/rev/078873f74ae5
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.