Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Introduce nsPIDOMWindow::GetDoc()

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Created attachment 648715 [details] [diff] [review]
Part a: Introduce it

For when you want to create the document if it doesn't exist yet, but you don't want an nsIDOMDocument
Attachment #648715 - Flags: review?(bugs)
(Assignee)

Comment 1

5 years ago
Created attachment 648716 [details] [diff] [review]
Part b: Use it in the special case for window.document in nsDOMClassInfo
Attachment #648716 - Flags: review?(bugs)
(Assignee)

Comment 2

5 years ago
Created attachment 648718 [details] [diff] [review]
Part c: Use it in drag&drop
Attachment #648718 - Flags: review?(bugs)
<bikeshed>
Could we call it GetOrCreate, so it's clear that it creates? (and rename any existing methods with this behavior to match)
</bikeshed>

Comment 4

5 years ago
Well, GetDocument can't be renamed.

Updated

5 years ago
Attachment #648715 - Flags: review?(bugs) → review+

Updated

5 years ago
Attachment #648716 - Flags: review?(bugs) → review+

Updated

5 years ago
Attachment #648718 - Flags: review?(bugs) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/18f2ed71b591
https://hg.mozilla.org/mozilla-central/rev/20521e4727d6
https://hg.mozilla.org/mozilla-central/rev/e94a0bfcac97
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Comment 6

5 years ago
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/integration/mozilla-inbound/rev/30332765790c
https://hg.mozilla.org/integration/mozilla-inbound/rev/6452d75c8b53
https://hg.mozilla.org/integration/mozilla-inbound/rev/909c1be5b6e4
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/30332765790c
https://hg.mozilla.org/mozilla-central/rev/6452d75c8b53
https://hg.mozilla.org/mozilla-central/rev/909c1be5b6e4
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.