Last Comment Bug 780165 - Introduce nsPIDOMWindow::GetDoc()
: Introduce nsPIDOMWindow::GetDoc()
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-03 08:29 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-08-04 18:40 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part a: Introduce it (2.69 KB, patch)
2012-08-03 08:29 PDT, :Ms2ger (⌚ UTC+1/+2)
bugs: review+
Details | Diff | Splinter Review
Part b: Use it in the special case for window.document in nsDOMClassInfo (1.34 KB, patch)
2012-08-03 08:29 PDT, :Ms2ger (⌚ UTC+1/+2)
bugs: review+
Details | Diff | Splinter Review
Part c: Use it in drag&drop (6.26 KB, patch)
2012-08-03 08:30 PDT, :Ms2ger (⌚ UTC+1/+2)
bugs: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-08-03 08:29:15 PDT
Created attachment 648715 [details] [diff] [review]
Part a: Introduce it

For when you want to create the document if it doesn't exist yet, but you don't want an nsIDOMDocument
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2012-08-03 08:29:54 PDT
Created attachment 648716 [details] [diff] [review]
Part b: Use it in the special case for window.document in nsDOMClassInfo
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-08-03 08:30:33 PDT
Created attachment 648718 [details] [diff] [review]
Part c: Use it in drag&drop
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-08-03 08:44:29 PDT
<bikeshed>
Could we call it GetOrCreate, so it's clear that it creates? (and rename any existing methods with this behavior to match)
</bikeshed>
Comment 4 Olli Pettay [:smaug] 2012-08-03 09:03:37 PDT
Well, GetDocument can't be renamed.
Comment 6 Ed Morley [:emorley] 2012-08-04 11:28:15 PDT
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f

Note You need to log in before you can comment on or make changes to this bug.