Last Comment Bug 780168 - Avoid a couple QIs in nsDocShell::GetInterface(nsIDocument)
: Avoid a couple QIs in nsDocShell::GetInterface(nsIDocument)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: :Ms2ger
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-03 08:40 PDT by :Ms2ger
Modified: 2012-08-04 18:40 PDT (History)
1 user (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.21 KB, patch)
2012-08-03 08:40 PDT, :Ms2ger
bzbarsky: review+
Details | Diff | Review

Description :Ms2ger 2012-08-03 08:40:54 PDT
Created attachment 648720 [details] [diff] [review]
Patch v1

mContentViewer->GetDOMDocument QIs the nsIDocument it has to nsIDOMDocument, just so we can QI it back.
Comment 1 Boris Zbarsky [:bz] 2012-08-03 12:12:44 PDT
Comment on attachment 648720 [details] [diff] [review]
Patch v1

r=me
Comment 3 Ed Morley [:emorley] 2012-08-04 11:28:10 PDT
Backed out with the mass tree revert to get rid of the OS X M5 orange:
https://hg.mozilla.org/mozilla-central/rev/c801b99d726f
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-04 14:51:51 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/47127a5b7ace
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-04 18:40:17 PDT
https://hg.mozilla.org/mozilla-central/rev/47127a5b7ace

Note You need to log in before you can comment on or make changes to this bug.