780213 - bogus INVALID_VALUE in DeleteTextures (esp. on Adreno)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: don't try to delete when len == 0

Adreno doesn't like glDeleteTextures with len == 0, even though it's supposed to be a no-op.  Instead, the driver spews to the android console and it generates a GL error.  Let's not do that.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 648765 [details] [diff] [review]
don't try to delete when len == 0

Review of attachment 648765 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/gfx/TextureReaper.java
@@ +6,4 @@
>  package org.mozilla.gecko.gfx;
>  
>  import android.opengl.GLES20;
> +import android.util.Log;

Not using this

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa100b9efcca

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aa100b9efcca