780246 - Kuma: Editor - Add a key shortcut to toggle <pre> mode

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[Eric Shepherd [:sheppy]]

This would help engineers that don't like toolbars insert code samples more quickly.

Comment 1

[David Walsh :davidwalsh]

How would they choose a language without the toolbar?

Comment 2

[Eric Shepherd [:sheppy]]

Well, they don't *have* to choose a language; you can have a bare <pre> block (indeed, we use these a lot in reference documentation; our syntax sections are not syntax highlighted because it just clutters up the function prototype).

But we could use the context menu on <pre> blocks to choose a language...

Comment 3

[David Walsh :davidwalsh]

Cool -- what keyboard shortcut would you like?

Comment 4

[Eric Shepherd [:sheppy]]

I don't have one in mind. We didn't have one on MindTouch; this is a New Feature Request.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/d3db4c9027fd1e2a9dbf83a2f8a66c344fe7b898
fix bug 780246 - Add keyboard shortcut for PRE

https://github.com/mozilla/kuma/commit/4c7bcf443b0bac088340c34147af445ec1a90c58
Merge pull request #493 from darkwing/pre-shortcut-780246

fix bug 780246 - Add keyboard shortcut for PRE

Comment 6

[John Karahalis [:openjck]]

Is the shortcut CTRL+P? Looks like Firefox overrides this with "Print".

Comment 7

[Eric Shepherd [:sheppy]]

We override Firefox's while in edit mode. It works for me anyway.

Comment 8

[David Walsh :davidwalsh]

Works for me in Firefox too.

Comment 9

[John Karahalis [:openjck]]

Now it is working for me. Not sure what I did wrong a second ago.