Context ui fails to dismiss after selecting an item from autocomplete

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
x86_64
Windows 8.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: completed-elm)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 648823 [details] [diff] [review]
patch

For landing on elm. I also added some header commenting.
(Assignee)

Updated

6 years ago
Attachment #648823 - Flags: review?(jonathan)
Comment on attachment 648823 [details] [diff] [review]
patch

Review of attachment 648823 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great.

Only comments I have are directed more at myself in regards to the ContextUIHelper's design.

Right now, the current way that we have partial visibility of ContextUI is by breaking encapsulation of ContextUIHelper and directly setting its visibility status.  I'm wondering whether it would make things easier to follow if I put in getters and setters for ContextUIHelper's isExpanded and isVisible properties that automatically fire ContextUI events when they're set and then have a separate method for setting partial visibility.

But, that might be overcomplicating things for the time being.
Attachment #648823 - Flags: review?(jonathan) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/projects/elm/rev/18bb4a6a079b
Whiteboard: completed-elm
(Assignee)

Updated

6 years ago
Component: Location Bar → General
Product: Firefox → Firefox for Metro
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.