For some applications, or just for testing purposes, it would be good to be able to disable the pulse listener in autophone.
Assignee: nobody → wlachance
Created attachment 648859 [details] [diff] [review] Add option to disable pulse listener
Attachment #648859 - Flags: review?(mcote)
Comment on attachment 648859 [details] [diff] [review] Add option to disable pulse listener So I like that the option is --disable-pulse, since the default would be to leave it running, but it strikes me as funny that the parameter to the AutoPhone constructor is "disable_pulse", in part because it doesn't default to True. It just seems funny for a function to take a mandatory parameter to disable something or not. I think I might switch it to "enable pulse" or something like that. But it's not terribly important. In fact, going forward, I think we'll want to specify more granularity in pulse options. Soon, autophone will just be listening to mozilla-central builds, or possibly just whatever build is most recent. So it might make sense at that point to configure the pulse listener via a config file or something. But I think that would benefit from more thought, so this patch is good for now.
Attachment #648859 - Flags: review?(mcote) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.