Closed Bug 780313 Opened 8 years ago Closed 8 years ago

Remove unnecessary preprocessing of Toolkit files

Categories

(Toolkit :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: Unfocused, Assigned: Unfocused)

References

Details

Attachments

(1 file)

Bug 770182 added warnings for when files are run through the preprocessor needlessly. Shock and horror, Toolkit wastes valuable resources when being built - those resources are worth their weight in gold!! We must fix this atrocity at once!
Attached patch Patch v1Splinter Review
Attachment #648896 - Flags: review?(dtownsend+bugmail)
Comment on attachment 648896 [details] [diff] [review]
Patch v1

>diff --git a/toolkit/mozapps/update/nsUpdateTimerManager.js b/toolkit/mozapps/update/nsUpdateTimerManager.js

There are a bunch of other comments in this file that are unnecessarily #-prefixed, should clean those up too.
Attachment #648896 - Flags: review?(dtownsend+bugmail) → review+
Pushed with the comments in nsUpdateTimerManager.js tweaked:

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d7b0289ccc7
https://hg.mozilla.org/mozilla-central/rev/5d7b0289ccc7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.