Closed Bug 780460 Opened 12 years ago Closed 6 years ago

Remove variable overrides for specific rules

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: glandium, Unassigned)

References

Details

(Whiteboard: [buildfaster:?]) 

We have a bunch of places where we use things like:

foo.$(OBJ_SUFFIX): CXXFLAGS += -someflag

There are actually several problems with that:
- the flag is not added for (what could be called) "intermediate" rules, such as those to create .s (assembly) or .i (preprocessed) output.
- it's not declarative in a very useful way for alternative build backends.
- if anything is built as a dependency of foo.$(OBJ_SUFFIX), it will be built with the additional CXXFLAGS.

I think we should have something similar to automake-type rules:
foo_c_CXXFLAGS = -someflag
Product: Core → Firefox Build System
It looks like we removed all of these in the transition to moz.build. Hooray!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.