Last Comment Bug 780728 - nsCanvasFrame.cpp:212:13: warning: variable ‘pixelRect’ set but not used [-Wunused-but-set-variable]
: nsCanvasFrame.cpp:212:13: warning: variable ‘pixelRect’ set but not used [-Wu...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Daniel Holbert [:dholbert]
:
Mentors:
Depends on:
Blocks: buildwarning dlbi
  Show dependency tree / graph
 
Reported: 2012-08-06 14:41 PDT by Daniel Holbert [:dholbert]
Modified: 2012-08-07 07:35 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Attachments
fix (1.24 KB, patch)
2012-08-06 14:44 PDT, Daniel Holbert [:dholbert] 		matt.woodrow: review+
Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Daniel Holbert [:dholbert] 2012-08-06 14:41:29 PDT 
Newish build warning:

{
layout/generic/nsCanvasFrame.cpp: In member function ‘virtual void nsDisplayCanvasBackground::Paint(nsDisplayListBuilder*, nsRenderingContext*)’:
layout/generic/nsCanvasFrame.cpp:212:13: warning: variable ‘pixelRect’ set but not used [-Wunused-but-set-variable]
}

This variable was added in this cset for Bug 539356...
  https://hg.mozilla.org/mozilla-central/rev/7a376ff3ae84
...but it's never used after its value's been set, as shown by this mxr search:
  https://mxr.mozilla.org/mozilla-central/search?string=pixelRect
Comment 1 Daniel Holbert [:dholbert] 2012-08-06 14:44:30 PDT 
Created attachment 649426 [details] [diff] [review]
fix
Comment 2 Daniel Holbert [:dholbert] 2012-08-06 14:56:51 PDT 
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bd439a357b7
Comment 3 Ed Morley [:emorley] 2012-08-07 07:35:40 PDT 
https://hg.mozilla.org/mozilla-central/rev/0bd439a357b7
Note You need to log in before you can comment on or make changes to this bug.