780806 - Changes in production_config et al not picked up by B2G/Thunderbird on reconfig

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

We thought the issue over in bug 657024, where some builders haven't picked up the clobberer domain change, was due to masters getting into old and crufty states. Actually this is reproducible in a freshly started master.

Eg set up a build master with current code, except revert attachment 642644 [details] [diff] [review]. Start it fresh. Connect to the manhole, and run

def show_clobs(): 
  b2g = master.botmaster.builders['B2G ics_armv7a_gecko-debug mozilla-central build'].buildFactory
  f = master.botmaster.builders['WINNT 5.2 mozilla-central build'].buildFactory
  t = master.botmaster.builders['TB WINNT 5.2 comm-central build'].buildFactory
  for i in (b2g, f, t):
    print "%s\n%s\n" % (i.baseName, i.clobberURL)

show_clobs()
B2G ics_armv7a_gecko-debug mozilla-central
http://build.mozilla.org/clobberer/index.php

WINNT 5.2 mozilla-central
http://build.mozilla.org/clobberer/index.php

TB WINNT 5.2 comm-central
http://build.mozilla.org/clobberer/index.php

Then apply attachment 642644 [details] [diff] [review] again, reconfig, and you get:
B2G ics_armv7a_gecko-debug mozilla-central
http://build.mozilla.org/clobberer/index.php

WINNT 5.2 mozilla-central
http://clobberer.pvt.build.mozilla.org/index.php

TB WINNT 5.2 comm-central
http://build.mozilla.org/clobberer/index.php

ie only the Firefox builder switched properly. Time to experiment with some reload lines.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Adding a 'reload(pc)' in mozilla/b2g_production_config.py gets:
B2G ics_armv7a_gecko-debug mozilla-central
http://clobberer.pvt.build.mozilla.org/index.php

WINNT 5.2 mozilla-central
http://clobberer.pvt.build.mozilla.org/index.php

TB WINNT 5.2 comm-central
http://build.mozilla.org/clobberer/index.php

but why do we have 
from production_config import GLOBAL_VARS, BUILDS_BEFORE_REBOOT, \
    SYMBOL_SERVER_HOST
in that file if we don't use it ?

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Nick Thomas [:nthomas] from comment #1)
> but why do we have 
> from production_config import GLOBAL_VARS, BUILDS_BEFORE_REBOOT, \
>     SYMBOL_SERVER_HOST
> in that file if we don't use it ?

Just an oversight, I assume. There was a bit of confusion when I handed off the initial Thunderbird configs to jhopkins and I guess this never got caught in testing/review.

(In reply to Nick Thomas [:nthomas] from comment #1)
> Adding a 'reload(pc)' in mozilla/b2g_production_config.py gets:

Woot. I'll try to fix up Thunderbird too, and do what I can to make sure this isn't going to cause any reconfig-order issues.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: fix reload by using localconfig instead of explicit names

So it seems this problem happened because we were referencing things like "production_config" in the b2g/thunderbird configs. I had assumed that they would be the same references as "localconfig", which is not the case. (In hindsight, that was a silly assumption to make!). By referencing localconfig here instead we inherit the reload() that config.py does on it. I tested locally and found that all clobberer references updated correctly (according to nthomas' STR) after a reconfig.

Comment 4

[Chris AtLee [:catlee]]

deployed via reconfig today

Comment 5

[[e-mail] (:bhearsum)]

Should be all good here now. Thanks a ton for your poking at this Nick, and sorry I waved this off last week!