Closed Bug 780825 Opened 8 years ago Closed 8 years ago

B2G RIL: Read code scheme 0x81, 0x82 UCS2 string on ICC

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

Attachments

(2 files, 5 obsolete files)

From TS 102.221, Annex A 
"UCS2 coding of Alpha fields for files residing on the UICC":

There are 3 coding schemes for UCS2 string on the UICC.

The first one and most common one(0x80) should be implemented in Bug 779885,
but the others( 0x81 and 0x82) are quite rare,
so I file this bug to handle these two rare cases.
Summary: B2G RIL: Read UCS2 String on ICC → B2G RIL: Read code scheme 0x81, 0x82 UCS2 string on ICC
I think the 0x81 one is the most common one in Europe. I had to implement it in my Gaia branch to properly import SIM contacts, and it’s really easy:
https://github.com/fabi1cazenave/gaia/blob/simContacts/apps/contacts/js/utilities/import_sim_contacts.js#L83
Hi kaze,
Thanks for the info.
I'll work on it
Assignee: nobody → allstars.chh
Status: NEW → ASSIGNED
Hi, Vicamo
This patch deals with 0x81 and 0x82 mode for UCS2 String on UICC. 
Would you help to review that?

Thanks
Attachment #650007 - Attachment is obsolete: true
Attachment #650457 - Flags: review?(vyang)
Attached patch Part 2: xpcshell tests (obsolete) — Splinter Review
Hi, Vicamo
Because currently we don't have writeICCUCS2String yet, so I collect the test data from a real SIM.

Thanks
Attachment #650458 - Flags: review?(vyang)
Comment on attachment 650457 [details] [diff] [review]
Part 1: Read 0x81 and 0x82 UCS2 String on UICC

Review of attachment 650457 [details] [diff] [review]:
-----------------------------------------------------------------

Wonderful!
Attachment #650457 - Flags: review?(vyang) → review+
Attached patch Part 2: xpcshell tests v2 (obsolete) — Splinter Review
update tests.
Attachment #650458 - Attachment is obsolete: true
Attachment #650458 - Flags: review?(vyang)
Attachment #650490 - Flags: review?(vyang)
Attached patch Part 2: xpcshell tests v3 (obsolete) — Splinter Review
update to use \u.

Thanks
Attachment #650490 - Attachment is obsolete: true
Attachment #650490 - Flags: review?(vyang)
Attachment #650765 - Flags: review?(vyang)
Comment on attachment 650765 [details] [diff] [review]
Part 2: xpcshell tests v3

Review of attachment 650765 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet!
Attachment #650765 - Flags: review?(vyang) → review+
Rebase to m-c
Attachment #650765 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.