Last Comment Bug 780860 - IonMonkey: Mark some instructions as movable
: IonMonkey: Mark some instructions as movable
Status: RESOLVED FIXED
[ion:p2]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Jan de Mooij [:jandem]
: general
Mentors:
Depends on:
Blocks: IonSpeed
  Show dependency treegraph
 
Reported: 2012-08-07 04:42 PDT by Jan de Mooij [:jandem]
Modified: 2012-08-08 09:53 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.46 KB, patch)
2012-08-07 04:42 PDT, Jan de Mooij [:jandem]
dvander: review+
Details | Diff | Splinter Review

Description Jan de Mooij [:jandem] 2012-08-07 04:42:19 PDT
Created attachment 649598 [details] [diff] [review]
Patch

Allows hoisting the Math.abs(j) in gaussian-blur. Not sure if this helps on tip too but it's definitely a small win once we favor OSR for outer loops.
Comment 1 Tom Schuster [:evilpie] 2012-08-07 04:54:07 PDT
What about sqrt?
Comment 2 Jan de Mooij [:jandem] 2012-08-07 06:50:26 PDT
(In reply to Tom Schuster [:evilpie] from comment #1)
> What about sqrt?

The patch marks MSqrt as movable too.
Comment 3 Jan de Mooij [:jandem] 2012-08-08 09:53:58 PDT
https://hg.mozilla.org/projects/ionmonkey/rev/c55e7945d3ab

Note You need to log in before you can comment on or make changes to this bug.