780961 - The maintenance service is not being used for zip builds

Status: RESOLVED INVALID

(Toolkit :: Application Update, defect)

Description

[(no longer active)]

We have a Vista laptop here at the office which seems to not use the maintenance service at all during updates.  I have performed some preliminary investigation on this and the log files do not reflect much on what's happening.

Unfortunately I don't have time to debug this right now.  Brian, should we arrange for the machine to be shipped to you so that you can take a look?

Comment 1

[Brian R. Bondy [:bbondy]]

I can provide my address if you think that's easiest, but I think it would be easiest just to install logmein.com and don't let the computer go to sleep, then email me the passcode to get in.

Comment 2

[(no longer active)]

(In reply to comment #1)
> I can provide my address if you think that's easiest, but I think it would be
> easiest just to install logmein.com and don't let the computer go to sleep,
> then email me the passcode to get in.

I tried doing that but logmein tells me that I need to log in from my own account...

Comment 3

[Brian R. Bondy [:bbondy]]

Can I send you an invite code tomorrow morning? I'll use gotomeeting or something like that.

Comment 4

[Brian R. Bondy [:bbondy]]

maybe like 10am EST?

Comment 5

[(no longer active)]

Sure.  Although 11am would probably be a better time if you wanna make sure that I'll be at the office.  Thanks!

Comment 6

[Brian R. Bondy [:bbondy]]

Sounds good Thx

Comment 7

[Brian R. Bondy [:bbondy]]

Let's try logmein rescue:

logmein123.com
Pin code: 989727

I think the code is only good for 15 min, so just ping me again for a new pin code when you don't get into the office if it's expired.

Comment 8

[Brian R. Bondy [:bbondy]]

new pin code: 715008

Comment 9

[Brian R. Bondy [:bbondy]]

app.update.url.override
http://people.mozilla.org/~eakhgari/snippets/test.xml

:D

Comment 10

[(no longer active)]

(In reply to comment #9)
> app.update.url.override
> http://people.mozilla.org/~eakhgari/snippets/test.xml
> 
> :D

No, I did that intentionally for testing.  The bug happens without it too, I think.

Comment 11

[Brian R. Bondy [:bbondy]]

oh ok, I'll send you another logmein.com pin tomorrow when you get in and I'll remove that and retest.  I have a meeting in 45min so tomorrow is best.

Comment 12

[(no longer active)]

(In reply to comment #11)
> oh ok, I'll send you another logmein.com pin tomorrow when you get in and I'll
> remove that and retest.  I have a meeting in 45min so tomorrow is best.

Sounds good!

Comment 13

[Brian R. Bondy [:bbondy]]

OK after uploading a few test builds I found out what's going on....

From common.nsh we do this:
; If the uninstall.log does not exist don't perform post update
; operations. This prevents updating the registry for zip builds.
IfFileExists "$EXEDIR\uninstall.log" +2 +1

So when there is a zip build , we don't have an uninstall.log file.  And when that file is not present we don't do a /PostUpdate operation.
uninstall.exe /PostUpdate is executed, but we don't actually call the PostUpdate macro.

The installdir never gets its registry key added which looks like this: HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\MaintenanceService\241e397d269a1e554c73095219c36ab9. The service needs to lookup the name and issuer cert key values from that key and if it is not present it bypasses the use of the service completely.

So the question is, do we want to:
1) Add the cert key always for zip builds from within common.nsh
2) Execute /PostUpdate from zip builds
3) Don't support using the service from zip builds and mark this as resolved / invalid.

Comment 14

[(no longer active)]

(In reply to comment #13)
> So the question is, do we want to:
> 1) Add the cert key always for zip builds from within common.nsh
> 2) Execute /PostUpdate from zip builds
> 3) Don't support using the service from zip builds and mark this as resolved /
> invalid.

I think (2) makes the most sense to me.

Comment 15

[Brian R. Bondy [:bbondy]]

I'm wondering what problems that will cause though, rstrong will probably know :)

Comment 16

[Robert Strong (they/them - no direct email)]

We bail early when running PostUpdate in zip builds because the people using zip builds filed bugs about us adding registry entries, etc. for zip builds. It is also used by Portable Firefox to prevent us from adding registry entries. I personally think 3 makes the most sense.