The default bug view has changed. See this FAQ.

Give providers a way to not support uncached mode

RESOLVED FIXED in 1.9

Status

Calendar
Internal Components
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 649778 [details] [diff] [review]
Fix - v1

Now that its easier for providers to support full offline mode we should head towards making providers use nothing but the cache. This patch removes the checkbox for the Cache when a new calendar property "cache.always" is set, and assumes the calendar is always cached in that case.

I've also taken the liberty to fix part of bug 768207 with this patch by renaming the cache label to "Offline Support". I left out the on-by-default part though until later on. I'd like to rewrite the ICS provider and fix bug 700637 before we do that.

I've tested cache-only providers in two cases and its going quite fine.
Attachment #649778 - Flags: review?(mohit.kanwal)
Comment on attachment 649778 [details] [diff] [review]
Fix - v1

Review of attachment 649778 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Does not break anything. Have tested adding new calendars and works.

::: calendar/base/content/dialogs/calendar-properties-dialog.js
@@ +12,1 @@
>  

Ha Ha! Nice!
Attachment #649778 - Flags: review?(mohit.kanwal) → review+
(Assignee)

Comment 2

5 years ago
Pushed to comm-central changeset 891e94861a14
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.9
You need to log in before you can comment on or make changes to this bug.