Last Comment Bug 780990 - Give providers a way to not support uncached mode
: Give providers a way to not support uncached mode
Product: Calendar
Classification: Client Software
Component: Internal Components (show other bugs)
: unspecified
: All All
-- normal (vote)
: 1.9
Assigned To: Philipp Kewisch [:Fallen]
Depends on:
  Show dependency treegraph
Reported: 2012-08-07 13:34 PDT by Philipp Kewisch [:Fallen]
Modified: 2012-08-16 06:20 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Fix - v1 (11.94 KB, patch)
2012-08-07 13:34 PDT, Philipp Kewisch [:Fallen]
mohit.kanwal: review+
Details | Diff | Splinter Review

Description User image Philipp Kewisch [:Fallen] 2012-08-07 13:34:43 PDT
Created attachment 649778 [details] [diff] [review]
Fix - v1

Now that its easier for providers to support full offline mode we should head towards making providers use nothing but the cache. This patch removes the checkbox for the Cache when a new calendar property "cache.always" is set, and assumes the calendar is always cached in that case.

I've also taken the liberty to fix part of bug 768207 with this patch by renaming the cache label to "Offline Support". I left out the on-by-default part though until later on. I'd like to rewrite the ICS provider and fix bug 700637 before we do that.

I've tested cache-only providers in two cases and its going quite fine.
Comment 1 User image Mohit Kanwal [:redDragon] 2012-08-16 04:52:32 PDT
Comment on attachment 649778 [details] [diff] [review]
Fix - v1

Review of attachment 649778 [details] [diff] [review]:

Looks good. Does not break anything. Have tested adding new calendars and works.

::: calendar/base/content/dialogs/calendar-properties-dialog.js
@@ +12,1 @@

Ha Ha! Nice!
Comment 2 User image Philipp Kewisch [:Fallen] 2012-08-16 06:20:50 PDT
Pushed to comm-central changeset 891e94861a14

Note You need to log in before you can comment on or make changes to this bug.