Closed
Bug 780997
Opened 13 years ago
Closed 13 years ago
update setup.py information for mozbase
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
References
Details
Attachments
(1 file)
6.42 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
Our setup.pys are fairly inconsistent. The owners should basically be
the A*Team, we shouldn't be using find_packages, etc.
Reporter | ||
Comment 1•13 years ago
|
||
This certainly isn't complete, but probably good to take. This patch:
* changes all permanent A*Team author info to the whole ateam
* corrects several email address copy+paste errors (yay copy + paste!)
* removes find_packages; why use this when we have one top-level module per package?
* other misc cleanup
This patch does not
* change versions
* change package names
* change license info
* etc
I would like to trend towards having a template that can be easily adopted. This is a step in the right direction IMHO
Attachment #649801 -
Flags: review?(wlachance)
Comment 2•13 years ago
|
||
Comment on attachment 649801 [details] [diff] [review]
cleanup
Looks good.
I notice that some entries for mozdevice and moztest (depending on which: author, author_email, url and license) are not in line with the rest of the items in the patch. Was that an oversight?
Attachment #649801 -
Flags: review?(wlachance) → review+
Reporter | ||
Comment 3•13 years ago
|
||
moztest I'd figured we'd leave Mihneadb as the author for now, though can be changed over later. I didn't fix license for any of them....not even sure what it should be (or if it matters). URL I also didn't try to unify except in a few cases where it was blatantly wrong.
Reporter | ||
Comment 4•13 years ago
|
||
pushed with some fixes: https://github.com/mozilla/mozbase/commit/831d170d7f0ba4de874517f3b9e9554b44033844
certainly not complete, but better.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•