781029 - Don't clobber config files in the deployment rpm

Status: VERIFIED WONTFIX

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Ryan Kelly [:rfkelly]]

The deployment rpm for server-storage includes a default config file.  When installed, this clobbers the puppetized config file and leads to much breakage.

I don't see any reason to include the config file in the RPM, we should just remove it.

Comment 1

[Bob Micheletto [:bobm]]

From the SyncStorage.spec file:
install -m 0644 etc/sync.conf %{buildroot}%{_sysconfdir}/sync/sync.conf

If that was changed to be a %config line like for the nginx configuration files, replacement shouldn't be a problem.  See the nginx lines from the same file:
# the config files for Sync apps
# nginx config
%config(noreplace) %{_sysconfdir}/sync/*
%config(noreplace) %{_sysconfdir}/nginx/conf.d/syncstorage.conf

Comment 2

[Ryan Kelly [:rfkelly]]

Attachment: use %config noreplace for all config files

Comment 3

[Ryan Kelly [:rfkelly]]

http://hg.mozilla.org/services/server-storage/rev/a3918623fd36

Comment 4

[Ryan Kelly [:rfkelly]]

Looks like this fix didn't work as intended, reopening the bug

Comment 5

[Ryan Kelly [:rfkelly]]

I've no clue as to why this is not working.  The tokenserver .spec file uses the same options on its bundled production.ini file, but this does not result the clobbering we see in sync stage.

It would be interesting to try this in a fresh VM and see if the clobbering still occurs.  Maybe it's some artifact of the state of the system rather than the rpm itself..?

Comment 6

[Ryan Kelly [:rfkelly]]

We have no plans to work on further sync1.1 process improvements like this